Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update search engine onboarding screen #16825

Closed
rebron opened this issue Jul 7, 2021 · 1 comment · Fixed by brave/brave-core#9397
Closed

update search engine onboarding screen #16825

rebron opened this issue Jul 7, 2021 · 1 comment · Fixed by brave/brave-core#9397
Assignees
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Jul 7, 2021

Description

Update search engine onboarding screen graphic and text.

Current result:

Screen Shot 2021-07-07 at 4 07 52 PM

Updated Design and Expected result:

Screen Shot 2021-07-09 at 12 16 37 PM

Figma link for assets:
https://www.figma.com/file/MFHpcXJMg2RUQpUJMAZZ4R/Desktop-Onboarding?node-id=2182%3A35486

Brave version (brave://version info)

Targeted for 1.27.x

Version/Channel Information:

n/a

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc: @karenkliu

@rebron rebron added OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. onboarding Front-end related to helping a new user learn about features within the browser. QA/Yes release-notes/exclude labels Jul 7, 2021
@bsclifton bsclifton self-assigned this Jul 9, 2021
bsclifton added a commit to brave/brave-core that referenced this issue Jul 9, 2021
bsclifton added a commit to brave/brave-core that referenced this issue Jul 12, 2021
bsclifton added a commit to brave/brave-core that referenced this issue Jul 13, 2021
@bsclifton bsclifton added this to the 1.28.x - Nightly milestone Jul 14, 2021
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 22, 2021

Verification passed on

Brave | 1.27.107 Chromium: 92.0.4515.107 (Official Build) (64-bit)
-- | --
Revision | 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS | Windows 10 OS Version 2004 (Build 19041.1110)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants