Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cr92 followup] Revert conversion of unit tests to static_library #16717

Closed
mkarolin opened this issue Jun 30, 2021 · 1 comment · Fixed by brave/brave-core#9297
Closed

[cr92 followup] Revert conversion of unit tests to static_library #16717

mkarolin opened this issue Jun 30, 2021 · 1 comment · Fixed by brave/brave-core#9297
Assignees
@mkarolin
Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Milestone
1.27.x - Release

Comments

@mkarolin
Copy link
Contributor

Unit tests that aren't in source_set don't get to run.

Unfortunately, this means that we will get a out of memory error when linking unit tests on Linux with DCHECKs turned on, but we'll have to find a different way of solving it.
@mkarolin mkarolin self-assigned this Jun 30, 2021
This was referenced Jun 30, 2021
Merged
Merged
@bsclifton
Copy link
Member

Fixed with brave/brave-core#9297

@bsclifton bsclifton added this to the 1.28.x - Nightly milestone Jul 1, 2021
@mkarolin mkarolin mentioned this issue Jul 7, 2021
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging a pull request may close this issue.

[cr92 followup] Revert static_library unit test targets brave/brave-core
3 participants
@bsclifton @LaurenWags @mkarolin