Crash in invalid-read when relaunching after setting new language as Brave's default

[stephendonner]

Description

Crash in invalid-read when relaunching after setting new language as Brave's default

Steps to Reproduce

1. new profile
2. open brave://settings/languages
3. click on Language to expand the dropdown
4. click on Add languages
5. type French and pick the 3rd option, French (France) - francais (France)
6. click Add
7. click on the 3-dots menu for French (France) and choose Display Brave in this language
8. click on the Relaunch button

Actual result:

Crash: here's the stack trace: https://share.backtrace.io/api/share/3IJdUd87Ds0jtdgNVClx1Y3

Expected result:

No crash; Brave should restart with French as its main language

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.26.16 Chromium: 91.0.4472.38 (Build officiel) nightly (64 bits)
Révision	8155e7afab5d695cf0e028f4d77203287523cda9-refs/branch-heads/4472_35@{#6}
Système d'exploitation	Windows 10 OS Version 2009 (Build 21376.1)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? No

[kjozwiak]

hmmm can't reproduce this on my machine. Tried it ~10 times and never received a crash after clicking on Relaunch. Used the following:

Brave | 1.26.16 Chromium: 91.0.4472.38 (Official Build) nightly (64-bit)
-- | --
Revision | 8155e7afab5d695cf0e028f4d77203287523cda9-refs/branch-heads/4472_35@{#6}
OS | Windows 10 OS Version 2009 (Build 19042.964)

Edition: Windows 10 Pro
Version : 20H2
Installed on : 2020-‎11-‎14
OS build: 19042.964
Experience: Windows Feature Experience Pack 120.2212.2020.0

Didn't have any luck reproducing it via a Win 10 x64 VM using Hyper-V either. Used the following:

Brave | 1.26.16 Chromium: 91.0.4472.38 (Official Build) nightly (64-bit)
--- | ---
Revision | 8155e7afab5d695cf0e028f4d77203287523cda9-refs/branch-heads/4472_35@{#6}
OS | Windows 10 OS Version 2009 (Build 19042.928)

Edition: Windows 10 Pro
Version: 20H2
Installed on: ‎3/‎23/‎2021
OS build: 19042.928
Experience: Windows Feature Experience Pack 120.2212.551.0

Most likely dependent on the Win version that's being used. Hopefully the stack narrows down the issue/cause.

[GeetaSarvadnya]

Issue isn't reproducible in Windows 10 x64 - Brave version 1.26.x

[iefremov]

@stephendonner for future reference: tab crashes are labeled as crash/webview

[stephendonner]

Additional crash IDs:

f0030700-b423-5206-0000-000000000000
f1030700-b423-5206-0000-000000000000
9df00600-b423-5206-0000-000000000000
9ef00600-b423-5206-0000-000000000000
e0030700-b423-5206-0000-000000000000
df030700-b423-5206-0000-000000000000
dd030700-b423-5206-0000-000000000000
dc030700-b423-5206-0000-000000000000
d6030700-b423-5206-0000-000000000000
eb030700-b423-5206-0000-000000000000
ee030700-b423-5206-0000-000000000000

I also see these in the console, leading up to the crash:

[4812:6764:0513/091648.533:WARNING:CONSOLE(1)] "Could not find style data in module named null", source: chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js (1)
[4812:6764:0513/091648.655:WARNING:CONSOLE(1)] "Could not find style data in module named null", source: chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js (1)
[4812:6764:0513/091648.825:WARNING:CONSOLE(1)] "method `shouldShowRestart_` not defined", source: chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js (1)
[4812:6764:0513/091648.898:VERBOSE2:tab_manager.cc(77)] Tab id 79 was updated
[4812:6764:0513/091648.898:VERBOSE6:user_activity.cc(41)] Triggered event: 11 (26:2:3600 s)
[4812:6764:0513/091649.027:WARNING:CONSOLE(1)] "HTML Imports is deprecated and has now been removed as of M80. See https://www.chromestatus.com/features/5144752345317376 and https://developers.google.com/web/updates/2019/07/web-components-time-to-upgrade for more details.", source: chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js (1)
[4812:6764:0513/091649.109:WARNING:CONSOLE(1)] "method `getProspectiveUILanguageName_` not defined", source: chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js (1)

[stephendonner]

Just a wild guess that something Polymer-related (given the console logs) is contributing to this - will re-test after https://github.com/brave/brave-core/pull/8800/files lands.

[stephendonner]

This now works for me (tested multiple times) using

Brave	1.27.51 Chromium: 91.0.4472.88 (Official Build) nightly (64-bit)
Revision	109e9cd038b94a631aea7d40ee3d56c1278f2597-refs/branch-heads/4472@{#1385}
OS	Windows 10 OS Version 2009 (Build 21390.1000)