Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private windows should use the sunglasses icon instead of the incognito secret-agent hat-and-glasses icon #1385

Closed
tildelowengrimm opened this issue Oct 1, 2018 · 5 comments

Comments

@tildelowengrimm
Copy link
Contributor

tildelowengrimm commented Oct 1, 2018

Instead of the people menu or the incognito hat-and-glasses, private windows should have the sunglasses logo.

46332729-7e71ee80-c5d2-11e8-8779-dd39edcb3289

@srirambv
Copy link
Contributor

srirambv commented Oct 2, 2018

Dupe of #738 ?

@bbondy
Copy link
Member

bbondy commented Oct 2, 2018

I think this is a partial dupe, this one sounds like it's also for the logo. Would you mind modifying to be specific to the logo @tomlowenthal ?

@tildelowengrimm tildelowengrimm changed the title Private windows should use the word "Private" instead of incognito hat-and-glasses logo Private windows should use an icon of the word "Private" instead of the incognito secret-agent hat-and-glasses logo Oct 2, 2018
@tildelowengrimm
Copy link
Contributor Author

tildelowengrimm commented Oct 2, 2018

This issue is only about the icon which appears where the avatar menu is in regular windows, the hat-and-glasses icon appears in private windows, and the word "Tor" appears in private windows with Tor. The change tracked by this issue is to replace the hat-and-glasses secret agent icon with the sunglasses ion in regular private windows. It's the matching issue to #1384 which puts the word "Tor" in private windows with Tor.

@tildelowengrimm tildelowengrimm changed the title Private windows should use an icon of the word "Private" instead of the incognito secret-agent hat-and-glasses logo Private windows should use the sunglasses icon instead of the incognito secret-agent hat-and-glasses icon Oct 2, 2018
@tildelowengrimm
Copy link
Contributor Author

@rossmoody can provide the asset for this.

@btlechowski
Copy link

btlechowski commented Oct 10, 2018

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows 7

image

Verified passed with

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment