Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https://diafygi.github.io/webrtc-ips/ leaks ip address when Block all fingerprinting protection is ON #15313

Closed
GeetaSarvadnya opened this issue Apr 15, 2021 · 4 comments · Fixed by brave/brave-core#8565
Closed

https://diafygi.github.io/webrtc-ips/ leaks ip address when Block all fingerprinting protection is ON #15313

GeetaSarvadnya opened this issue Apr 15, 2021 · 4 comments · Fixed by brave/brave-core#8565
Assignees
@samartnik
Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Test-Plan-Specified QA/Yes regression release/blocking release-notes/exclude security
Milestone
1.23.x - Release #2

Comments

@GeetaSarvadnya
Copy link

Description

https://diafygi.github.io/webrtc-ips/ leaks ip address when Block all fingerprinting protection is ON

Steps to reproduce

  1. Clean profile 1.23.x
  2. Open https://diafygi.github.io/webrtc-ips in a new tab
  3. Observe that IP Address is shown
  4. Open shield and turn ON Block all fingerprinting protection FP settings

Actual result

https://diafygi.github.io/webrtc-ips/ leaks ip address when Block all fingerprinting protection is ON

Expected result

https://diafygi.github.io/webrtc-ips/ shouldn't leak the IP Address

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? Not sure
  • Can you reproduce this issue with the current Play Store Nightly version? Yes in 1.25.18

Device details

  • Install type (ARM, x86): all
  • Device type (Phone, Tablet, Phablet): all
  • Android version: Samsung galaxy Tab 10

Brave version

1.23.71

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/legacy_qa @SergeyZhukovsky @samartnik
@GeetaSarvadnya GeetaSarvadnya added QA/Yes QA/Test-Plan-Specified regression OS/Android Fixes related to Android browser functionality labels Apr 15, 2021
@ryanbr
Copy link

ryanbr commented Apr 15, 2021 •
edited
Loading

From Brave Beta (new profile) I'm not seeing an IP address @GeetaSarvadnya

#edit, was testing on Desktop not Android.

@srirambv
Copy link
Contributor

srirambv commented Apr 15, 2021 •
edited
Loading

Repro'd on OnePlus 6T with Android 10 runnin 1.23.71 x64 build. Issue only happens on the test link from issue description. Using browserleaks.com/webrtc produces the same result on both GPS build 1.22.71 and RC build 1.23.71

@anthonypkeane anthonypkeane added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 15, 2021
@anthonypkeane
Copy link

Linked to #7487

@samartnik samartnik self-assigned this Apr 15, 2021
@kjozwiak kjozwiak added this to the 1.23.x - Release #2 milestone Apr 15, 2021
@samartnik samartnik mentioned this issue Apr 19, 2021
Merged
24 tasks
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.23.73 x64 build

  • Verified test plan from issue description
Android.ARM.WebRTC.mp4

Verification passed on Samsung Tab A with Android 10 running 1.23.73 x64 build

  • Verified test plan from issue description
Android.Tab.WebRTC.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Test-Plan-Specified QA/Yes regression release/blocking release-notes/exclude security
Projects
None yet
Milestone
1.23.x - Release #2
Development

Successfully merging a pull request may close this issue.

[Android] Fixes for WebRTC IP leak issue brave/brave-core
7 participants
@diracdeltas @ryanbr @kjozwiak @anthonypkeane @srirambv @samartnik @GeetaSarvadnya