Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fixes for WebRTC IP leak issue #8565

Merged
merged 4 commits into from
Apr 20, 2021
Merged

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Apr 19, 2021

Resolves brave/brave-browser#15313

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 19, 2021
@samartnik samartnik added this to the 1.25.x - Nightly milestone Apr 19, 2021
@samartnik samartnik self-assigned this Apr 19, 2021
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik force-pushed the android_webrtc_policy branch from f62564b to db0ac44 Compare April 20, 2021 01:13
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jumde jumde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@samartnik samartnik merged commit 449125f into master Apr 20, 2021
@samartnik samartnik deleted the android_webrtc_policy branch April 20, 2021 16:57
@samartnik samartnik restored the android_webrtc_policy branch April 20, 2021 17:05
@samartnik samartnik deleted the android_webrtc_policy branch April 20, 2021 17:29
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.25.31 x64 nightly build

  • Verified local IP is not leaked on https://diafygi.github.io/webrtc-ips/ irrespective of fingerprint settings

kylehickinson pushed a commit that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https://diafygi.github.io/webrtc-ips/ leaks ip address when Block all fingerprinting protection is ON
6 participants