Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a a button to go to brave://adblock/ in the right click menu and maybe change 'Brave' name. #14978

Closed
ghost opened this issue Mar 26, 2021 · 3 comments · Fixed by brave/brave-core#8394

Comments

@ghost
Copy link

ghost commented Mar 26, 2021

Test plan

See brave/brave-core#8394

Description

Following brave/brave-core#8156 and #14945

Then I would like to suggest a button in the menu to go to brave://adblock/ page so people who only used the old deprecated adblock feature will be able to access the rules without problem and getting lost because the "clear css" button that was removed.
I know when #8838 happens (if it is still a thing) could make things easier for some people to find where the rules are, it will be more intuitive for sure, because right now adblock page being accessible only through the 'hamburger' menu I know it is not so much for some people.

Also like the title says, maybe a change on the Brave right click menu could also be good, so reflects more it is about the adblock feature instead of being a general "Brave" that can be used for anything, unless there are plans to add more stuff to the menu that have nothing to do with Brave's adblocker, why not rename it to Brave Adblock or Brave Shields if there is more plans to add shield settings to it?

@ghost ghost added the OS/Desktop label Mar 26, 2021
@bsclifton bsclifton added feature/settings feature/shields/adblock Blocking ads & trackers with Shields labels Mar 28, 2021
@bsclifton
Copy link
Member

cc: @rebron @karenkliu

@antonok-edm antonok-edm self-assigned this Mar 30, 2021
@antonok-edm antonok-edm added privacy-pod Feature work for the Privacy & Web Compatibility pod QA/Yes release-notes/include labels Mar 30, 2021
@bsclifton bsclifton added this to the 1.24.x - Nightly milestone Apr 4, 2021
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 5, 2021
@stephendonner
Copy link

stephendonner commented Apr 5, 2021

Verified PASSED using

Brave 1.23.68 Chromium: 90.0.4430.51 (Official Build) (x86_64)
Revision 32e5fa33a31641bded70a90e60121060691e7125-refs/branch-heads/4430@{#927}
OS macOS Version 11.2.3 (Build 20D91)

Steps:

  1. loaded cnn.com in a single tab
  2. right-clicked on the page, and chose Brave -> Manage custom filters
  3. confirmed I was taken to brave://adblock/ in a new tab
  4. loaded cnn.com in a tab; in a 2nd tab, opened brave://adblock/
  5. switched back to cnn.com tab and chose Brave -> Manage custom filters
  6. confirmed I was taken back to the open brave://adblock tab
  7. loaded brave://adblock/ in a single tab
  8. right-clicked on the page, and chose Brave -> Manage custom filters
  9. confirmed I remained on brave://adblock in the current tab

Screen Shot 2021-04-08 at 2 16 06 PM

Screen Shot 2021-04-08 at 2 16 50 PM


Verification passed on

Brave | 1.23.68 Chromium: 90.0.4430.51 (Official Build) (64-bit)
-- | --
Revision | 32e5fa33a31641bded70a90e60121060691e7125-refs/branch-heads/4430@{#927}
OS | Windows 10 OS Version 2004 (Build 19041.867)


Verified passed with

Brave	1.23.68 Chromium: 90.0.4430.51 (Official Build) (64-bit)
Revision	32e5fa33a31641bded70a90e60121060691e7125-refs/branch-heads/4430@{#927}
OS	Linux

Verified test plan from brave/brave-core#8394
Confirmed Brave > Manage custom filters context menu item exists and click on it navigates to a new or already opened brave://adblock tab.

context menu

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 5, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Apr 6, 2021

Added QA/Test-All-Platforms as right click context menu's usually differ between different platforms.

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA Pass-macOS QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants