Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side bar keeps showing up even when video enters full screen mode #14402

Closed
srirambv opened this issue Mar 1, 2021 · 1 comment · Fixed by brave/brave-core#8430
Closed

Side bar keeps showing up even when video enters full screen mode #14402

srirambv opened this issue Mar 1, 2021 · 1 comment · Fixed by brave/brave-core#8430
Assignees
Labels
enhancement feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 1, 2021

Description

Side bar keeps showing up even when video enters full screen mode

Steps to Reproduce

  1. Enable sidebar flag from brave:flags
  2. Set side bar to show always
  3. Open a video link and enter full screen
  4. Side bar keeps showing on full screen video

Actual result:

Side bar shows on full screen videos

Expected result:

Always show side bar should only be on browser normal view. If you enter a video to fullscreen should hide sidebar and not distract video viewing

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.23.5 Chromium: 89.0.4389.58 (Official Build) nightly (64-bit)
Revision 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @simonhong @karenkliu

@stephendonner
Copy link

Verified FIXED using the inline steps to reproduce, on nightly build

Brave 1.25.11 Chromium: 90.0.4430.61 (Official Build) nightly (x86_64)
Revision dced74d4124b26b14126b611853d33512b60c7b6-refs/branch-heads/4430@{#1115}
OS macOS Version 11.2.3 (Build 20D91)

Steps

  1. enabled sidebar flag from brave:flags
  2. set side bar to show always
  3. opened a video link from hbomax.com and clicked View | Enter Full Screen
  4. maximized video via the HBO Max on-screen controls

Confirmed there's no sidebar present after entering full-screen mode

video with sidebar full-screen mode, no sidebar
Screen Shot 2021-04-12 at 4 15 44 PM Screen Shot 2021-04-12 at 4 16 07 PM

@simonhong simonhong added the feature/sidebar Relating to Brave's Sidebar feature label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants