Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor accessibility cleanup #14176

Closed
iefremov opened this issue Feb 16, 2021 · 1 comment · Fixed by brave/brave-core#7970
Closed

Minor accessibility cleanup #14176

iefremov opened this issue Feb 16, 2021 · 1 comment · Fixed by brave/brave-core#7970

Comments

@iefremov
Copy link
Contributor

Setup proper accessibility info in our UI elements.

For QA: In MacOS accessibility settings enable "Hover text" and "Typing feedback" and check that hovering speedreader and bookmark buttons (with Cmd pressed to trigger hover text) works as expected. Also check that creating/closing many tabs quickly works as expected.

@iefremov iefremov self-assigned this Feb 16, 2021
iefremov added a commit to brave/brave-core that referenced this issue Feb 16, 2021
Set proper accessibility propeties for our buttons and
drop stale patch.

Fix brave/brave-browser#14176
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 16, 2021
iefremov added a commit to brave/brave-core that referenced this issue Mar 15, 2021
Set proper accessibility propeties for our buttons.

Fix brave/brave-browser#14176
@iefremov iefremov added this to the 1.24.x - Nightly milestone Mar 17, 2021
@stephendonner
Copy link

stephendonner commented Mar 22, 2021

Verified PASSED on Brave 1.24.11 Chromium: 89.0.4389.90 (Official Build) nightly (x86_64)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS macOS Version 11.2.3 (Build 20D91)

On macOS Big Sur (11.2.3) I tested:

  • the Hover text accessibility feature with the Speedreader and Bookmark button UI elements (unable to catch a screenshot of the tooltips, due to timing issue)
  • Speak typing feedback
  • quickly opening and closing many tabs
Hover text Speak typing feedback
Screen Shot 2021-03-22 at 3 04 12 PM Screen Shot 2021-03-22 at 3 04 22 PM

Leaving issue unverified, so we (others) can check and verify those two features more fully, on Catalina/Mojave, as well, if (probably) needed 👍


Verified passed with

Brave | 1.24.81 Chromium: 90.0.4430.93 (Official Build) (x86_64)
-- | --
Revision | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS | macOS Version 10.15.7 (Build 19H1030)

Confirmed hovertext worked on Speedreader and Bookmark buttons (with CMD selected).
Confirmed able to quickly open/close many tabs/windows with these accessibility features enabled.

Settings used:

Example Example
settings settings2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants