Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser crash when relaunching browser after widevine is enabled through settings #14146

Closed
btlechowski opened this issue Feb 13, 2021 · 1 comment · Fixed by brave/brave-core#7959
Closed

Browser crash when relaunching browser after widevine is enabled through settings #14146

btlechowski opened this issue Feb 13, 2021 · 1 comment · Fixed by brave/brave-core#7959
Assignees
@simonhong
Labels
crash OS/Desktop OS/Linux plugin/Widevine QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.21.x - Release

Comments

@btlechowski
Copy link

btlechowski commented Feb 13, 2021 •
edited
Loading

Follow up to #2791
On Linux when user enables widevine, we show a modal to relaunch the browser, clicking Allow will crash the browser

Steps to Reproduce

  1. Clean profile
  2. Enable widevine through brave://settings/extensions
  3. Wait till widevine modal is shown
  4. Click Allow

Note: Clicking Relaunch will not crash

Actual result:

Crash
image

Expected result:

No crash

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.21.52 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS
Brave 1.22.23 Chromium: 89.0.4389.48 (Official Build) nightly (64-bit)
Revision 0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
OS Linux

cc @brave/legacy_qa @rebron @Brave-Matt @simonhong
@btlechowski btlechowski mentioned this issue Feb 13, 2021
Closed
@simonhong simonhong self-assigned this Feb 15, 2021
simonhong added a commit to brave/brave-core that referenced this issue Feb 15, 2021
@simonhong
Fix crash while relaunching after installing widevine
8783b21 
fix brave/brave-browser#14146

It seems PermissionRequestManager is destroyed by calling
chrome::AttemptRelaunch() before PermissionRequest accept handler
is not finished. To fix this, post AttempRelaunch() instead of calling
it in current turn.
@simonhong simonhong mentioned this issue Feb 15, 2021
Merged
23 tasks
@brave-builds brave-builds mentioned this issue Feb 15, 2021
Merged
7 tasks
@btlechowski
Copy link
Author

Verification passed on

Verification passed on

Brave 1.21.64 Chromium: 88.0.4324.182 (Official Build) beta (64-bit)
Revision 73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS Ubuntu 18.04 LTS

Verified test plan from #14146.
Verified the modal is not shown, therefor the client does not crash.
image
Verified clicking Relaunch now, relaunches the browser
Verified able to play neftlix

Verified able to install widevine through Install Widevine modal
image

Verified able to play neftlix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
crash OS/Desktop OS/Linux plugin/Widevine QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.21.x - Release
Development

Successfully merging a pull request may close this issue.

Fix crash while relaunching after installing widevine brave/brave-core
3 participants
@kjozwiak @simonhong @btlechowski