Crash on opening .onion link #13736

rkfg · 2021-01-23T12:58:33Z

Description

Brave crashes when you open a second .onion link

Steps to Reproduce

Enable "Automatically redirect .onion sites".
Click this link: Blockchain.
A tor window should open.
If this tab disappears, press Ctrl+Shift+T to restore it.
Click the link above again.
Alternatively click the link above with middle button (mouse wheel), a tor window appears and the browser crashes immediately.

Actual result:

Brave crashes completely (segmentation fault)

Expected result:

The link opens normally

Reproduces how often:

Every single time.

Brave version (brave://version info)

Brave	1.19.86 Chromium: 88.0.4324.96 (Official Build) (64-bit)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	Linux (Debian testing)
JavaScript	V8 8.8.278.14

Version/Channel Information:

Can you reproduce this issue with the current release? yes
Can you reproduce this issue with the beta channel? yes
Can you reproduce this issue with the nightly channel? yes

NumDeP · 2021-01-23T14:02:28Z

I'm think this may be related to the issue I created #13723

Are you able to check brave://crashes to see if a report was generated?

rkfg · 2021-01-23T14:04:06Z

Looks like it's disabled for me:

NumDeP · 2021-01-23T14:21:33Z

@rkfg I don't it's disabled. I noticed that it's enabled by default but it just doesn't generate a report, though I'm not sure if that means they actually received it or not. I have it enabled but nothing shows up.

Check it, it should be toggled under -

Help improve Brave's features and performance
Automatically sends usage statistics and crash reports to Brave

rkfg · 2021-01-23T14:25:59Z

Ok, I enabled it, relaunched the browser and crashed Brave again but there's nothing new on that tab. It doesn't say that reporting is disabled now though.

Can you reproduce the crash? Just click that link in the OP with the middle button, should crash instantly.

NumDeP · 2021-01-23T14:33:46Z

Do you have two different types of browser windows open i.e normal or private window along side tor window?

Clicking on that link doesn't seem to load. I'm using it via Tor window right now.

Every time I've noticed a crash it's always been whenever I've have a separate window alongside tor window.

rkfg · 2021-01-23T14:37:33Z

Do you have two different types of browser windows open i.e normal or private window along side tor window?

I have a normal one with many tabs, when I click the link with the middle button a new window (a private tor window I presume) appears but then both disappear and I see a segfault message in dmesg. The messages aren't very informative and the numbers are different every time:

[331356.548800] brave[3231717]: segfault at 7ffd065d7ff8 ip 00005591fafdcbc8 sp 00007ffd065d8000 error 6 in brave[5591f687b000+87e2000]
[331356.548805] Code: 00 00 4d 89 f0 48 83 c4 08 5b 41 5c 41 5d 41 5e 41 5f 5d e9 0a 00 00 00 cc cc cc cc cc cc cc cc cc cc 55 48 89 e5 41 57 41 56 <41> 55 41 54 53 48 81 ec 58 01 00 00 4d 89 c7 89 d3 64 48 8b 04 25
[331370.060656] brave[3250726]: segfault at 7ffec9eccff8 ip 000055f4976fd098 sp 00007ffec9ecd000 error 6 in brave[55f493e89000+87e2000]
[331370.060661] Code: 48 8b 05 7b fc 71 05 48 89 47 68 0f ae f0 f0 48 0f b1 3d 6b fc 71 05 75 02 5d c3 cc 0f 0b cc cc cc cc 55 48 89 e5 41 57 41 56 <41> 55 41 54 53 50 4c 8b 3d 4b fc 71 05 49 8b 07 4c 8d 25 d1 d9 d2
[336332.819265] brave[3273214]: segfault at 7ffca8d10ff8 ip 000055e907ffadec sp 00007ffca8d11000 error 6 in brave[55e903ead000+87d3000]
[336332.819270] Code: 24 03 00 00 00 48 83 c4 08 5b 41 5c 41 5d 41 5e 41 5f 5d c3 0f 0b cc cc cc cc cc cc cc cc 55 48 89 e5 41 57 41 56 41 55 41 54 <53> 48 83 ec 78 64 48 8b 04 25 28 00 00 00 48 89 45 d0 0f 28 05 7b

Clicking on that link doesn't seem to load. I'm using it via Tor window right now.

It's probably a dead site, I found it in Google. But whether it works or not is unrelated as the crash happens on opening this private tor window.

Every time I've noticed a crash it's always been whenever I've have a separate window alongside tor window.

That's the case then I think. I reproduced it in beta and nightly as well, the nightly version doesn't even have any extensions installed and it still crashes like the rest. Might be a Linux-specific issue, idk.

rebron · 2021-01-25T16:28:03Z

cc: @darkdh Can you take a look when you get a chance?

darkdh · 2021-01-25T20:38:16Z

This seems like linux specific, I can't reproduce it on MacOS. Here is the call stack

#0  0x00007f5b03e99d01 in bool url::(anonymous namespace)::DoSimpleHost<char, char>(char const*, int, url::CanonOutputT<char>*, bool*) () at /home/darkdh/Projects/brave-browser/src/out/Component/liburl.so
#1  0x00007f5b03e99787 in bool url::(anonymous namespace)::DoHostSubstring<char, unsigned char>(char const*, url::Component const&, url::CanonOutputT<char>*) () at /home/darkdh/Projects/brave-browser/src/out/Component/liburl.so
#2  0x00007f5b03e99237 in void url::(anonymous namespace)::DoHost<char, unsigned char>(char const*, url::Component const&, url::CanonOutputT<char>*, url::CanonHostInfo*) () at /home/darkdh/Projects/brave-browser/src/out/Component/liburl.so
#3  0x00007f5b03e991c8 in url::CanonicalizeHost(char const*, url::Component const&, url::CanonOutputT<char>*, url::Component*) () at /home/darkdh/Projects/brave-browser/src/out/Component/liburl.so
#4  0x00007f5b03ea2ee9 in bool url::(anonymous namespace)::DoCanonicalizeStandardURL<char, unsigned char>(url::URLComponentSource<char> const&, url::Parsed const&, url::SchemeType, url::CharsetConverter*, url::CanonOutputT<char>*, url::Parsed*) ()
    at /home/darkdh/Projects/brave-browser/src/out/Component/liburl.so
#5  0x00007f5b03ea2d53 in url::CanonicalizeStandardURL(char const*, int, url::Parsed const&, url::SchemeType, url::CharsetConverter*, url::CanonOutputT<char>*, url::Parsed*) () at /home/darkdh/Projects/brave-browser/src/out/Component/liburl.so
#6  0x00007f5b03ea732c in bool url::(anonymous namespace)::DoCanonicalize<char>(char const*, int, bool, url::(anonymous namespace)::WhitespaceRemovalPolicy, url::CharsetConverter*, url::CanonOutputT<char>*, url::Parsed*) ()
    at /home/darkdh/Projects/brave-browser/src/out/Component/liburl.so
#7  0x00007f5b03ea6f4c in url::Canonicalize(char const*, int, bool, url::CharsetConverter*, url::CanonOutputT<char>*, url::Parsed*) () at /home/darkdh/Projects/brave-browser/src/out/Component/liburl.so
#8  0x00007f5b03e8aee8 in void GURL::InitCanonical<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > >(base::BasicStringPiece<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > >, bool) ()
    at /home/darkdh/Projects/brave-browser/src/out/Component/liburl.so
#9  0x00007f5b033f916b in content::(anonymous namespace)::SchemeAndHostToSite(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > const&, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > const&) ()
    at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#10 0x00007f5b033f9228 in content::SiteInstanceImpl::GetSiteForOrigin(url::Origin const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#11 0x00007f5b033f8c7a in content::SiteInstanceImpl::GetSiteForURLInternal(content::IsolationContext const&, content::UrlInfo const&, bool) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#12 0x00007f5b033f6920 in content::SiteInstanceImpl::ComputeSiteInfo(content::IsolationContext const&, content::UrlInfo const&, bool, base::Optional<url::Origin> const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#13 0x00007f5b02e55ce1 in content::BrowsingInstance::GetSiteInstanceForURLHelper(content::UrlInfo const&, bool) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#14 0x00007f5b02e55eaf in content::BrowsingInstance::GetSiteInfoForURL(content::UrlInfo const&, bool) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#15 0x00007f5b033f50f2 in content::SiteInstanceImpl::SetSite(content::UrlInfo const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#16 0x00007f5b02e55c4e in content::BrowsingInstance::GetSiteInstanceForURL(content::UrlInfo const&, bool) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17 0x00007f5b033f2f1a in content::SiteInstanceImpl::CreateForUrlInfo(content::BrowserContext*, content::UrlInfo const&, bool) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#18 0x00007f5b033f62f9 in content::SiteInstance::CreateForURL(content::BrowserContext*, GURL const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#19 0x000055740e31da11 in tab_util::GetSiteInstanceForNewTab(Profile*, GURL) ()
#20 0x000055740f41ef9c in Navigate(NavigateParams*) ()
#21 0x000055740f408a93 in Browser::OpenURLFromTab(content::WebContents*, content::OpenURLParams const&) ()
#22 0x000055740f406a9c in Browser::OpenURL(content::OpenURLParams const&) ()
#23 0x000055740dae95d9 in tor::(anonymous namespace)::OnTorProfileCreated(GURL, Profile*, Profile::CreateStatus) ()
#24 0x000055740dae96db in base::internal::Invoker<base::internal::BindState<void (*)(GURL, Profile*, Profile::CreateStatus), GURL>, void (Profile*, Profile::CreateStatus)>::Run(base::internal::BindStateBase*, Profile*, Profile::CreateStatus) ()
#25 0x000055740e3cb226 in profiles::OpenBrowserWindowForProfile(base::RepeatingCallback<void (Profile*, Profile::CreateStatus)>, bool, bool, bool, Profile*, Profile::CreateStatus) ()
#26 0x000055740de22dd2 in TorProfileManager::SwitchToTorProfile(Profile*, base::RepeatingCallback<void (Profile*, Profile::CreateStatus)>) ()
#27 0x000055740de22d33 in tor::OnionLocationNavigationThrottleDelegate::OpenInTorWindow(content::WebContents*, GURL) ()
#28 0x000055740de1ced8 in tor::OnionLocationNavigationThrottle::WillStartRequest() ()
#29 0x00007f5b0324b48b in content::NavigationThrottleRunner::ProcessInternal() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#30 0x00007f5b0324b2aa in content::NavigationThrottleRunner::ProcessNavigationEvent(content::NavigationThrottleRunner::Event) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#31 0x00007f5b03233720 in content::NavigationRequest::WillStartRequest() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#32 0x00007f5b0322fa1d in content::NavigationRequest::BeginNavigation() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#33 0x00007f5b0324e2f4 in content::Navigator::Navigate(std::__Cr::unique_ptr<content::NavigationRequest, std::__Cr::default_delete<content::NavigationRequest> >, content::ReloadType, content::RestoreType) ()
    at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#34 0x00007f5b0321672a in content::NavigationControllerImpl::NavigateWithoutEntry(content::NavigationController::LoadURLParams const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#35 0x00007f5b0321558f in content::NavigationControllerImpl::LoadURLWithParams(content::NavigationController::LoadURLParams const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#36 0x000055740f4202f8 in (anonymous namespace)::LoadURLInContents(content::WebContents*, GURL const&, NavigateParams*) ()
#37 0x000055740f41f343 in Navigate(NavigateParams*) ()
#38 0x000055740f408a93 in Browser::OpenURLFromTab(content::WebContents*, content::OpenURLParams const&) ()
#39 0x000055740f406a9c in Browser::OpenURL(content::OpenURLParams const&) ()
#40 0x000055740dae95d9 in tor::(anonymous namespace)::OnTorProfileCreated(GURL, Profile*, Profile::CreateStatus) ()
#41 0x000055740dae96db in base::internal::Invoker<base::internal::BindState<void (*)(GURL, Profile*, Profile::CreateStatus), GURL>, void (Profile*, Profile::CreateStatus)>::Run(base::internal::BindStateBase*, Profile*, Profile::CreateStatus) ()
#42 0x000055740e3cb226 in profiles::OpenBrowserWindowForProfile(base::RepeatingCallback<void (Profile*, Profile::CreateStatus)>, bool, bool, bool, Profile*, Profile::CreateStatus) ()
#43 0x000055740de22dd2 in TorProfileManager::SwitchToTorProfile(Profile*, base::RepeatingCallback<void (Profile*, Profile::CreateStatus)>) ()
#44 0x000055740de22d33 in tor::OnionLocationNavigationThrottleDelegate::OpenInTorWindow(content::WebContents*, GURL) ()
#45 0x000055740de1ced8 in tor::OnionLocationNavigationThrottle::WillStartRequest() ()
#46 0x00007f5b0324b48b in content::NavigationThrottleRunner::ProcessInternal() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#47 0x00007f5b0324b2aa in content::NavigationThrottleRunner::ProcessNavigationEvent(content::NavigationThrottleRunner::Event) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#48 0x00007f5b03233720 in content::NavigationRequest::WillStartRequest() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#49 0x00007f5b0322fa1d in content::NavigationRequest::BeginNavigation() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#50 0x00007f5b0324e2f4 in content::Navigator::Navigate(std::__Cr::unique_ptr<content::NavigationRequest, std::__Cr::default_delete<content::NavigationRequest> >, content::ReloadType, content::RestoreType) ()
    at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#51 0x00007f5b0321672a in content::NavigationControllerImpl::NavigateWithoutEntry(content::NavigationController::LoadURLParams const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#52 0x00007f5b0321558f in content::NavigationControllerImpl::LoadURLWithParams(content::NavigationController::LoadURLParams const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#53 0x000055740f4202f8 in (anonymous namespace)::LoadURLInContents(content::WebContents*, GURL const&, NavigateParams*) ()
#54 0x000055740f41f343 in Navigate(NavigateParams*) ()
#55 0x000055740f408a93 in Browser::OpenURLFromTab(content::WebContents*, content::OpenURLParams const&) ()
#56 0x000055740f406a9c in Browser::OpenURL(content::OpenURLParams const&) ()
#57 0x000055740dae95d9 in tor::(anonymous namespace)::OnTorProfileCreated(GURL, Profile*, Profile::CreateStatus) ()
#58 0x000055740dae96db in base::internal::Invoker<base::internal::BindState<void (*)(GURL, Profile*, Profile::CreateStatus), GURL>, void (Profile*, Profile::CreateStatus)>::Run(base::internal::BindStateBase*, Profile*, Profile::CreateStatus) ()
#59 0x000055740e3cb226 in profiles::OpenBrowserWindowForProfile(base::RepeatingCallback<void (Profile*, Profile::CreateStatus)>, bool, bool, bool, Profile*, Profile::CreateStatus) ()                           
#60 0x000055740de22dd2 in TorProfileManager::SwitchToTorProfile(Profile*, base::RepeatingCallback<void (Profile*, Profile::CreateStatus)>) ()
#61 0x000055740de22d33 in tor::OnionLocationNavigationThrottleDelegate::OpenInTorWindow(content::WebContents*, GURL) ()                                                                                       
#62 0x000055740de1ced8 in tor::OnionLocationNavigationThrottle::WillStartRequest() ()                                      
#63 0x00007f5b0324b48b in content::NavigationThrottleRunner::ProcessInternal() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#64 0x00007f5b0324b2aa in content::NavigationThrottleRunner::ProcessNavigationEvent(content::NavigationThrottleRunner::Event) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#65 0x00007f5b03233720 in content::NavigationRequest::WillStartRequest() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#66 0x00007f5b0322fa1d in content::NavigationRequest::BeginNavigation() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#67 0x00007f5b0324e2f4 in content::Navigator::Navigate(std::__Cr::unique_ptr<content::NavigationRequest, std::__Cr::default_delete<content::NavigationRequest> >, content::ReloadType, content::RestoreType) ()
    at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
...
#629 0x00007f5b0321672a in content::NavigationControllerImpl::NavigateWithoutEntry(content::NavigationController::LoadURLParams const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#630 0x00007f5b0321558f in content::NavigationControllerImpl::LoadURLWithParams(content::NavigationController::LoadURLParams const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#631 0x000055740f4202f8 in (anonymous namespace)::LoadURLInContents(content::WebContents*, GURL const&, NavigateParams*) ()
#632 0x000055740f41f343 in Navigate(NavigateParams*) ()
#633 0x000055740f408a93 in Browser::OpenURLFromTab(content::WebContents*, content::OpenURLParams const&) ()
#634 0x000055740f406a9c in Browser::OpenURL(content::OpenURLParams const&) ()
#635 0x000055740dae95d9 in tor::(anonymous namespace)::OnTorProfileCreated(GURL, Profile*, Profile::CreateStatus) ()
#636 0x000055740dae96db in base::internal::Invoker<base::internal::BindState<void (*)(GURL, Profile*, Profile::CreateStatus), GURL>, void (Profile*, Profile::CreateStatus)>::Run(base::internal::BindStateBase*, Profile*, Profile::CreateStatus) ()
#637 0x000055740e3cb226 in profiles::OpenBrowserWindowForProfile(base::RepeatingCallback<void (Profile*, Profile::CreateStatus)>, bool, bool, bool, Profile*, Profile::CreateStatus) ()
#638 0x000055740de22dd2 in TorProfileManager::SwitchToTorProfile(Profile*, base::RepeatingCallback<void (Profile*, Profile::CreateStatus)>) ()
#639 0x000055740de22d33 in tor::OnionLocationNavigationThrottleDelegate::OpenInTorWindow(content::WebContents*, GURL) ()
#640 0x000055740de1ced8 in tor::OnionLocationNavigationThrottle::WillStartRequest() ()
#641 0x00007f5b0324b48b in content::NavigationThrottleRunner::ProcessInternal() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#642 0x00007f5b0324b2aa in content::NavigationThrottleRunner::ProcessNavigationEvent(content::NavigationThrottleRunner::Event) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#643 0x00007f5b03233720 in content::NavigationRequest::WillStartRequest() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#644 0x00007f5b0322fa1d in content::NavigationRequest::BeginNavigation() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#645 0x00007f5b0324e2f4 in content::Navigator::Navigate(std::__Cr::unique_ptr<content::NavigationRequest, std::__Cr::default_delete<content::NavigationRequest> >, content::ReloadType, content::RestoreType) ()
    at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
...
#17205 0x00007fcdbab42dd3 in content::NavigationControllerImpl::NavigateWithoutEntry(content::NavigationController::LoadURLParams const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17206 0x00007fcdbab41cef in content::NavigationControllerImpl::LoadURLWithParams(content::NavigationController::LoadURLParams const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17207 0x0000557b977de3b8 in (anonymous namespace)::LoadURLInContents(content::WebContents*, GURL const&, NavigateParams*) ()
#17208 0x0000557b977dd60d in Navigate(NavigateParams*) ()
#17209 0x0000557b977c78e3 in Browser::OpenURLFromTab(content::WebContents*, content::OpenURLParams const&) ()
#17210 0x0000557b977c5b0c in Browser::OpenURL(content::OpenURLParams const&) ()
#17211 0x0000557b95e75de9 in tor::(anonymous namespace)::OnTorProfileCreated(GURL, Profile*, Profile::CreateStatus) ()
#17212 0x0000557b95e75e5b in base::internal::Invoker<base::internal::BindState<void (*)(GURL, Profile*, Profile::CreateStatus), GURL>, void (Profile*, Profile::CreateStatus)>::Run(base::internal::BindStateBase*, Profile*, Profile::CreateStatus) ()
#17213 0x0000557b96780dcc in profiles::OpenBrowserWindowForProfile(base::RepeatingCallback<void (Profile*, Profile::CreateStatus)>, bool, bool, bool, Profile*, Profile::CreateStatus) ()
#17214 0x0000557b961b9a43 in TorProfileManager::SwitchToTorProfile(Profile*, base::RepeatingCallback<void (Profile*, Profile::CreateStatus)>) ()
#17215 0x0000557b961b9953 in tor::OnionLocationNavigationThrottleDelegate::OpenInTorWindow(content::WebContents*, GURL) ()
#17216 0x0000557b961a2456 in tor::OnionLocationNavigationThrottle::WillStartRequest() ()
#17217 0x00007fcdbab7998e in content::NavigationThrottleRunner::ProcessInternal() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17218 0x00007fcdbab797c0 in content::NavigationThrottleRunner::ProcessNavigationEvent(content::NavigationThrottleRunner::Event) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17219 0x00007fcdbab6133a in content::NavigationRequest::WillStartRequest() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17220 0x00007fcdbab5d06a in content::NavigationRequest::BeginNavigation() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17221 0x00007fcdbab7dc4d in content::Navigator::BeforeUnloadCompleted(content::FrameTreeNode*, bool, base::TimeTicks const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17222 0x00007fcdbabb66b9 in base::internal::Invoker<base::internal::BindState<content::RenderFrameHostImpl::ProcessBeforeUnloadCompletedFromFrame(bool, bool, content::RenderFrameHostImpl*, bool, base::TimeTicks const&, base::TimeTicks const&)::$_4, base::WeakPtr<content::R
enderFrameHostImpl>, base::TimeTicks, bool, bool>, void ()>::RunOnce(base::internal::BindStateBase*) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17223 0x00007fcdbab88410 in content::RenderFrameHostImpl::ProcessBeforeUnloadCompletedFromFrame(bool, bool, content::RenderFrameHostImpl*, bool, base::TimeTicks const&, base::TimeTicks const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17224 0x00007fcdbab969db in content::RenderFrameHostImpl::ProcessBeforeUnloadCompleted(bool, bool, base::TimeTicks const&, base::TimeTicks const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17225 0x00007fcdbabb7406 in void base::internal::FunctorTraits<void (content::RenderFrameHostImpl::*)(bool, bool, base::TimeTicks const&, base::TimeTicks const&), void>::Invoke<void (content::RenderFrameHostImpl::*)(bool, bool, base::TimeTicks const&, base::TimeTicks const
&), base::WeakPtr<content::RenderFrameHostImpl>, bool, bool, base::TimeTicks, base::TimeTicks>(void (content::RenderFrameHostImpl::*)(bool, bool, base::TimeTicks const&, base::TimeTicks const&), base::WeakPtr<content::RenderFrameHostImpl>&&, bool&&, bool&&, base::TimeTicks&
&, base::TimeTicks&&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17226 0x00007fcdbabb7349 in base::internal::Invoker<base::internal::BindState<void (content::RenderFrameHostImpl::*)(bool, bool, base::TimeTicks const&, base::TimeTicks const&), base::WeakPtr<content::RenderFrameHostImpl>, bool, bool, base::TimeTicks, base::TimeTicks>, voi
d ()>::RunOnce(base::internal::BindStateBase*) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17227 0x00007fcdbccb625b in base::TaskAnnotator::RunTask(char const*, base::PendingTask*) () at /home/darkdh/Projects/brave-browser/src/out/Component/libbase.so
#17228 0x00007fcdbccd1ddd in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*) () at /home/darkdh/Projects/brave-browser/src/out/Component/libbase.so
#17229 0x00007fcdbccd1a40 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() () at /home/darkdh/Projects/brave-browser/src/out/Component/libbase.so
#17230 0x00007fcdbcc57877 in base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*) () at /home/darkdh/Projects/brave-browser/src/out/Component/libbase.so
#17231 0x00007fcdacf55fbd in g_main_context_dispatch () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#17232 0x00007fcdacf56240 in  () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#17233 0x00007fcdacf562e3 in g_main_context_iteration () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#17234 0x00007fcdbcc57432 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) () at /home/darkdh/Projects/brave-browser/src/out/Component/libbase.so
#17235 0x00007fcdbccd2816 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) () at /home/darkdh/Projects/brave-browser/src/out/Component/libbase.so
#17236 0x00007fcdbcc91b35 in base::RunLoop::Run() () at /home/darkdh/Projects/brave-browser/src/out/Component/libbase.so
#17237 0x0000557b9649cf2f in ChromeBrowserMainParts::MainMessageLoopRun(int*) ()
#17238 0x00007fcdba76aa38 in content::BrowserMainLoop::RunMainMessageLoopParts() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17239 0x00007fcdba76d332 in content::BrowserMainRunnerImpl::Run() () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17240 0x00007fcdba767cda in content::BrowserMain(content::MainFunctionParams const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17241 0x00007fcdbb1ea38a in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17242 0x00007fcdbb1e9e75 in content::ContentMainRunnerImpl::Run(bool) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17243 0x00007fcdbb1e7a0a in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17244 0x00007fcdbb1e7afc in content::ContentMain(content::ContentMainParams const&) () at /home/darkdh/Projects/brave-browser/src/out/Component/libcontent.so
#17245 0x0000557b956df1ea in ChromeMain ()
#17246 0x00007fcdac72f0b3 in __libc_start_main (main=0x557b956df0f0 <main>, argc=4, argv=0x7ffd80d81a88, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffd80d81a78) at ../csu/libc-start.c:308

And it is stuck in a endless loop of
content::Navigator::Navigate ... content::NavigationControllerImpl::NavigateWithoutEntry

rkfg · 2021-01-25T21:23:15Z

I'm not sure if it's a different bug but the current tab shouldn't close/crash/disappear when you click an .onion link like it does now.

btlechowski · 2021-01-26T01:26:48Z

Thanks for reporting @rkfg

I can easily reproduce the issue on

Brave	1.20.88 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	Ubuntu 18.04 LTS

Brave	1.21.26 Chromium: 88.0.4324.96 (Official Build) nightly (64-bit)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	Ubuntu 18.04 LTS

Steps:

Clean profile
Turn on Automatically redirect .onion sites in brave://settings/extensions
In normal Window open: https://brave5t5rjjg3s6k.onion/ <- wait for the page to load
In normal Window open: https://brave5t5rjjg3s6k.onion/ again

Result:
Crash

darkdh · 2021-01-27T01:15:42Z

I'm not sure if it's a different bug but the current tab shouldn't close/crash/disappear when you click an .onion link like it does now.

@rkfg it is also fixed in the PR

btlechowski · 2021-02-14T14:52:49Z

Verification passed on

Brave	1.21.52 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	Ubuntu 18.04 LTS

Verified test plan from #13736 (comment)
Verified no crash.

Verified test plan from brave/brave-core#7713
Verified only 2 tor tabs are opened.

stephendonner · 2021-02-22T18:40:45Z

I know this wasn't reported to be crashing on macOS, but I tested around the issue, just in case, using

Brave	1.21.62 Chromium: 88.0.4324.182 (Official Build) beta (x86_64)
Revision	73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS	macOS Version 11.2.1 (Build 20D74)

Not adding QA Pass-macOS label since I can't reproduce the original problem, though.

btlechowski · 2021-02-24T13:49:11Z

Verification passed on

Brave	1.20.110 Chromium: 88.0.4324.192 (Official Build) (64-bit)
Revision	31b458a18f133db9203eb5a5dd6552de0716dda3-refs/branch-heads/4324_182@{#6}
OS	Ubuntu 18.04 LTS

Verified test plan from #13736 (comment)
Verified no crash.

Verified test plan from brave/brave-core#7713
Verified only 2 tor tabs are opened.

From brave/brave-core#7713:

Brave	1.20.110 Chromium: 88.0.4324.192 (Official Build) (x86_64)
Revision	31b458a18f133db9203eb5a5dd6552de0716dda3-refs/branch-heads/4324_182@{#6}
OS	macOS Version 11.2.1 (Build 20D74)

Brave	1.20.110 Chromium: 88.0.4324.192 (Official Build) (64-bit)
Revision	31b458a18f133db9203eb5a5dd6552de0716dda3-refs/branch-heads/4324_182@{#6}
OS	Windows 10 OS Version 2009 (Build 21318.1000)

Verified we don't crash on macOS nor Windows 10 - x64
Verified we only have single Tor tabs, and that we didn't close the .com tab, for both https://brave5t5rjjg3s6k.onion and http://expyuzz4wqqyqhjn.onion/index.html

rkfg added the OS/Desktop label Jan 23, 2021

rebron added OS/Linux feature/tor crash labels Jan 25, 2021

darkdh self-assigned this Jan 25, 2021

This was referenced Jan 26, 2021

Onion addresses spawn new tor private window #13236

Closed

Brave Crashed Twice - No Crash Report Sent #13723

Closed

darkdh mentioned this issue Jan 27, 2021

Fix infinite OpenInTorWindow looping when auto redirect through navigation throttle. brave/brave-core#7713

Merged

23 tasks

darkdh added QA/Test-Plan-Specified QA/Yes release-notes/include labels Jan 27, 2021

darkdh closed this as completed in brave/brave-core#7713 Jan 27, 2021

darkdh added this to the 1.21.x - Nightly milestone Jan 27, 2021

btlechowski added the QA Pass-Linux label Feb 14, 2021

darkdh mentioned this issue Feb 23, 2021

Block .onion requests in non-Tor window (uplift to 1.20.x) brave/brave-core#8051

Merged

7 tasks

kjozwiak modified the milestones: 1.21.x - Release, 1.20.x - Release #3 Feb 24, 2021

LaurenWags mentioned this issue Feb 24, 2021

Release Notes for 1.20.x Release #3 #14319

Closed

stephendonner added QA Pass-macOS QA Pass-Win64 labels Feb 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crash on opening .onion link #13736

Crash on opening .onion link #13736

rkfg commented Jan 23, 2021 •

edited

Loading

NumDeP commented Jan 23, 2021

rkfg commented Jan 23, 2021

NumDeP commented Jan 23, 2021

rkfg commented Jan 23, 2021

NumDeP commented Jan 23, 2021

rkfg commented Jan 23, 2021 •

edited

Loading

rebron commented Jan 25, 2021

darkdh commented Jan 25, 2021 •

edited

Loading

rkfg commented Jan 25, 2021

btlechowski commented Jan 26, 2021

darkdh commented Jan 27, 2021

btlechowski commented Feb 14, 2021

stephendonner commented Feb 22, 2021

btlechowski commented Feb 24, 2021 •

edited by stephendonner

Loading

Crash on opening .onion link #13736

Crash on opening .onion link #13736

Comments

rkfg commented Jan 23, 2021 • edited Loading

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

NumDeP commented Jan 23, 2021

rkfg commented Jan 23, 2021

NumDeP commented Jan 23, 2021

rkfg commented Jan 23, 2021

NumDeP commented Jan 23, 2021

rkfg commented Jan 23, 2021 • edited Loading

rebron commented Jan 25, 2021

darkdh commented Jan 25, 2021 • edited Loading

rkfg commented Jan 25, 2021

btlechowski commented Jan 26, 2021

darkdh commented Jan 27, 2021

btlechowski commented Feb 14, 2021

stephendonner commented Feb 22, 2021

btlechowski commented Feb 24, 2021 • edited by stephendonner Loading

rkfg commented Jan 23, 2021 •

edited

Loading

rkfg commented Jan 23, 2021 •

edited

Loading

darkdh commented Jan 25, 2021 •

edited

Loading

btlechowski commented Feb 24, 2021 •

edited by stephendonner

Loading