Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out Wicked Reports trackers from URLs #13647

Closed
fmarier opened this issue Jan 19, 2021 · 2 comments · Fixed by brave/brave-core#7651
Closed

Filter out Wicked Reports trackers from URLs #13647

fmarier opened this issue Jan 19, 2021 · 2 comments · Fixed by brave/brave-core#7651

Comments

@fmarier
Copy link
Member

fmarier commented Jan 19, 2021

Wicked Reports uses a WickedID query string parameter to track clicks associated with a specific Facebook ad.

Since Facebook ads can be very finely targeted, this is potentially much broader targeting that the general campaign-level targeting we let through.

Examples seen in the wild:

  • https://www.globusjourneys.ca/tour/west-coast-escape/k8c/?nextyear=true&utm_source=Facebook&utm_medium=KSM&WickedSource=Facebook&WickedID=23846328971330060
  • https://www.avalonwaterways.ca/River-Cruise-Deals/?wickedsource=google&wickedid=437638785839&wtm_term=avalon%20waterways&wtm_campaign=9465020561&wtm_content=106987737532&wickedplacement=&wickedkeyword=avalon%20waterways?utm_source=ksm&utm_medium=gsearch
  • https://www.coachesrising.com/neuroscienceofchange/?utm_campaign=Noc20&utm_source=facebook&utm_medium=advert&utm_content=sp-cold-lookalike&WickedSource=Facebook&WickedID=6211096177678#!
@stephendonner
Copy link

stephendonner commented Feb 9, 2021

Verified FIXED using the testplan from brave/brave-core#7651, on:

Brave 1.21.44 Chromium: 88.0.4324.146 (Official Build) beta (x86_64)
Revision 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS macOS Version 11.2 (Build 20D64)
Open `https://brave.com/?WickedID=1234` and confirm that there is no `WickedID` parameter in the URL bar.

image


Verification passed on

Brave 1.21.56 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS

Verified testplan from brave/brave-core#7651

Open `https://brave.com/?WickedID=1234` and confirm that there is no `WickedID` parameter in the URL bar.

image

Verified the examples from the description


Verification passed on


Brave | 1.21.56 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
-- | --
Revision | 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS | Windows 10 OS Version 2004 (Build 19041.804)

Open `https://brave.com/?WickedID=1234` and confirm that there is no `WickedID` parameter in the URL bar.

image

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.21.69 x64 build

  • Verified visiting https://brave.com/?WickedID=1234 doesn't include ?WickedID=1234 parameter in the URL bar
    image
Links from issue description
image image image

Verification passed on Samsung Tab A with Android 10 running 1.21.69 x64 build

  • Verified visiting https://brave.com/?WickedID=1234 doesn't include ?WickedID=1234 parameter in the URL bar
    image
Links from issue description
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment