Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wording on the BR widget #13397

Closed
jenn-rhim opened this issue Jan 6, 2021 · 6 comments · Fixed by brave/brave-core#7786
Closed

Fix the wording on the BR widget #13397

jenn-rhim opened this issue Jan 6, 2021 · 6 comments · Fixed by brave/brave-core#7786
Assignees
Labels
design A design change, especially one which needs input from the design team feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@jenn-rhim
Copy link

jenn-rhim commented Jan 6, 2021

Description

Incorrect wordings on the widget in nightly.

Steps to Reproduce

Actual result:

image

Expected result:

  1. Change 'Get paid' to 'Earn rewards'
  2. Change "Brave Ads" to "Brave Private Ads"
  3. Change 'By clicking rewardsWidgetEarnAndGive, you agree to...' to 'By proceeding, you agree to...'

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@kjozwiak kjozwiak added design A design change, especially one which needs input from the design team feature/rewards QA/Yes labels Jan 7, 2021
@ryanml ryanml assigned ryanml and unassigned ryanml Jan 10, 2021
@rebron
Copy link
Collaborator

rebron commented Jan 15, 2021

@zenparsing when you get a chance can you take a look?

@zenparsing zenparsing added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 21, 2021
@rebron
Copy link
Collaborator

rebron commented Jan 27, 2021

related to: #8361

@zenparsing zenparsing self-assigned this Jan 27, 2021
@zenparsing
Copy link

@jenn-rhim What should the full text of the title be?

Perhaps this?

Earn rewards for viewing this sponsored background image.

@zenparsing
Copy link

@jenn-rhim I was able to put together the following quick fix:

Screen Shot 2021-02-02 at 12 18 51 PM

The wording of the terms of service links match the wording elsewhere in the widget. If we want to change it to "By proceeding, ..." the fix will take a bit longer.

Let me know if this works.

@zenparsing
Copy link

TOS text will be normalized in a followup: #13936.

@stephendonner
Copy link

stephendonner commented Feb 9, 2021

Verified FIXED using

Brave 1.21.47 Chromium: 88.0.4324.152 (Official Build) beta (x86_64)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS macOS Version 11.2 (Build 20D64)

Checked that @jenn-rhim's suggestions are in, with the exception of the Terms of Service text, which will be addressed in #13936:

  1. "Get paid to view..." -> "Earn rewards for viewing..."
  2. "Turn on Brave Ads" -> "Turn on Brave Private Ads"

Screen Shot 2021-02-08 at 5 05 52 PM


Verification passed on

Brave 1.21.52 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS
  1. "Get paid to view..." -> "Earn rewards for viewing..."
  2. "Turn on Brave Ads" -> "Turn on Brave Private Ads"

image
image


Verified passed with

Brave	1.21.55 Chromium: 88.0.4324.152 (Official Build) beta (64-bit)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	Windows 10 OS Version 1909 (Build 18363.1256)

Verified widget text matches #13397 (comment)

Screen Shot 2021-02-16 at 4 04 50 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants