Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoplay blocked indicator is shown even though global autoplay settings is set to allowed #13027

Closed
GeetaSarvadnya opened this issue Dec 3, 2020 · 9 comments
Labels
closed/duplicate Issue has already been reported

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 3, 2020

Description

Found while testing #10811
Autoplay blocked indicator is shown even though global autoplay settings is set to allowed

Steps to Reproduce

  1. Clean profile 1.18.68
  2. Open brave://settings/content/autoplay and set global autoplay settings to Blocked
  3. Open https://www.escapistmagazine.com/v2/the-change-architect-is-a-free-glimpse-behind-the-scenes-of-a-tense-political-protest/ in a new tab and ensure autoplay blocked indicator is shown in the URL bar
  4. Navigate to brave://settings/content/autoplay and set global autoplay settings to Allowed
  5. Reload the www.escapistmagazine.com which is opened in step 3
  6. Autoplay blocked indicator is shown in the URL bar
  7. Open brave://settings/clearBrowserData and delete all-time browsing data
  8. Repeat step 5
  9. Autoplay blocked indicator is still shown in the URL bar

Actual result:

Autoplay blocked indicator is shown even though global autoplay settings is set to allowed

Expected result:

Autoplay blocked indicator should not be shown when global autoplay settings is set to allowed

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.18.68 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS Windows 10 OS Version 2004 (Build 19041.630)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @darkdh @pes10k @rebron

@darkdh
Copy link
Member

darkdh commented Dec 3, 2020

did you see the ask prompt? if so it is actually the duped of #12795

@darkdh
Copy link
Member

darkdh commented Dec 4, 2020

could you open Preference file under your profile to see if there is a "default_content_setting_values": {"autoplay":3} after quitting Brave?

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". labels Dec 7, 2020
@rebron rebron removed the priority/P4 Planned work. We expect to get to it "soon". label Dec 8, 2020
@GeetaSarvadnya
Copy link
Author

@darkdh I am seeing the ask prompt below when global autoplay is "Blocked" or "Allowed"
image

@darkdh
Copy link
Member

darkdh commented Dec 9, 2020

sorry I meant this prompt
Screen Shot 2020-12-08 at 22 22 14

@GeetaSarvadnya
Copy link
Author

@darkdh I am seeing the "default_content_setting_values":{"autoplay":2,"cookies":1} in Preference file.

@GeetaSarvadnya
Copy link
Author

@darkdh I am getting the Ask Promot on YT only when global autoplay is "Allowed"

image

@darkdh
Copy link
Member

darkdh commented Dec 9, 2020

That is the bug of #12795

@darkdh
Copy link
Member

darkdh commented Dec 9, 2020

And if you check default_content_setting_values again after exiting Brave, you will see "autoplay": 3

@GeetaSarvadnya
Copy link
Author

Now I could see "default_content_setting_values":{"autoplay":3,"cookies":1}, in Preference file. I am ging to close the issue as dup of #12795

@GeetaSarvadnya GeetaSarvadnya added the closed/duplicate Issue has already been reported label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

3 participants