Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add to Brave" only appears in English #12526

Closed
gabrc52 opened this issue Nov 5, 2020 · 2 comments
Closed

"Add to Brave" only appears in English #12526

gabrc52 opened this issue Nov 5, 2020 · 2 comments
Labels
closed/duplicate Issue has already been reported l10n OS/Android Fixes related to Android browser functionality OS/Desktop

Comments

@gabrc52
Copy link

gabrc52 commented Nov 5, 2020

Description

On the Chrome web store, the "Add to Chrome" button says "Add to Brave instead". However, this only happens in the English language, and not in other languages. Other languages still say Chrome.

Steps to Reproduce

  1. Open a Chrome extension on the Chrome web store

Actual result:

"Add to Chrome" in non-English language

Expected result:

"Add to Brave" in non-English language

Reproduces how often:

Easily reproduced

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@gabrc52 gabrc52 added OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 5, 2020
@srirambv srirambv added the l10n label Nov 5, 2020
@btlechowski
Copy link

@gabrc52 Is this a dupe of #10570?

@gabrc52
Copy link
Author

gabrc52 commented Nov 17, 2020

Yes, except this talks about non English languages in general, explicitly

@gabrc52 gabrc52 closed this as completed Nov 17, 2020
@bbondy bbondy added the closed/duplicate Issue has already been reported label Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported l10n OS/Android Fixes related to Android browser functionality OS/Desktop
Projects
None yet
Development

No branches or pull requests

4 participants