Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Add to Brave is not replaced in non-EN locales #10570

Closed
btlechowski opened this issue Jul 6, 2020 · 10 comments · Fixed by brave/brave-core#17416
Closed

[Desktop] Add to Brave is not replaced in non-EN locales #10570

btlechowski opened this issue Jul 6, 2020 · 10 comments · Fixed by brave/brave-core#17416
Assignees
@emerick
Labels
branding bug l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.50.x - Release

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Run Brave in Polish locale
  2. Open https://chrome.google.com/webstore/detail/google-translate/aapbdbdomjkkjkaonfhkkikfgjllcleb

Actual result:

Add to Brave is translated to Dodaj do Chrome
image
image

Expected result:

Add to Brave is translated to Dodaj do Brave

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.10.90 Chromium: 83.0.4103.97 (Official Build) (64-bit)
Revision 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS Ubuntu 18.04 LTS
Brave 1.11.89 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS Ubuntu 18.04 LTS
Brave 1.12.73 Chromium: 84.0.4147.68 (Official Build) nightly (64-bit)
Revision e7b7234037639b407e69c5428c891ce018cd6c0d-refs/branch-heads/4147@{#772}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @mkarolin @rebron @simonhong
@bsclifton
Copy link
Member

I don't think there's anything we can do here?

Basically, there is a content script looking at this page which just replaced Chrome with Brave. @btlechowski can you confirm how this looks in Chrome?

As Google owns this page, we can't do anything

@btlechowski
Copy link
Author

We are already changing Chrome to Brave in English
image
image

Chrome in Polish:
image

@bsclifton
Copy link
Member

bsclifton commented Jul 7, 2020 •
edited
Loading

ah - sorry. For some reason, I thought the issue being reported was a poor translation. This is definitely something actionable we should be able to fix 😄

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jul 7, 2020
@bsclifton bsclifton removed their assignment Jul 20, 2020
@btlechowski
Copy link
Author

Still reproducible

Brave 1.16.67 Chromium: 86.0.4240.111 (Official Build) (64-bit)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS Ubuntu 18.04 LTS

image

@btlechowski btlechowski mentioned this issue Oct 22, 2020
Closed
@btlechowski btlechowski mentioned this issue Nov 17, 2020
Closed
@gabrc52
Copy link

gabrc52 commented Nov 17, 2020 •
edited
Loading

Can reproduce in Spanish as well. It’s most likely present on all non-English languages, so the title should be updated to reflect this.

@srirambv srirambv changed the title [Desktop] Add to Brave is translated to Dodaj do Chrome in Polish locale [Desktop] Add to Brave is translated to Dodaj do Chrome for non-EN locales Nov 17, 2020
@rebron
Copy link
Collaborator

rebron commented Mar 2, 2021

cc: @emerick Is this something we can fix via Greaslion? I suspect we'd need to bring in Add to Brave into Greaselion as well.

@emerick
Copy link
Contributor

emerick commented Mar 2, 2021

Yes, seems fixable via a Greaselion script.

@emerick emerick changed the title [Desktop] Add to Brave is translated to Dodaj do Chrome for non-EN locales [Desktop] Add to Brave is not replaced in non-EN locales Feb 28, 2023
@emerick emerick self-assigned this Feb 28, 2023
@emerick emerick mentioned this issue Feb 28, 2023
Merged
25 tasks
@emerick emerick added this to the 1.50.x - Nightly milestone Mar 1, 2023
@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Blocked and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 17, 2023
@LaurenWags
Copy link
Member

Labelling as QA/Blocked for now, as this cannot be checked until we get translations (see brave/brave-core#17416 (review)). Thanks for working through this with me @emerick!

@LaurenWags
Copy link
Member

Translations were uplifted via #29387 so this can be tested in 1.50.113 and above.

@LaurenWags LaurenWags mentioned this issue Apr 4, 2023
Closed
@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 4, 2023
@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.50.113 Chromium: 112.0.5615.49 (Oficjalna wersja) (64-bitowa)
-- | --
Wersja | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
System operacyjny | Windows 10 Version 21H2 (Build 19044.2728)
  • Verified the description from the issue and ensured that Add to Brave is translated to Dodaj do Brave in Polish locale

image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
branding bug l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

Properly replace Add to Chrome in non-English locales brave/brave-core
7 participants
@bsclifton @emerick @rebron @gabrc52 @LaurenWags @btlechowski @GeetaSarvadnya