Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update links from Crypto.com #12304

Closed
rebron opened this issue Oct 23, 2020 · 2 comments · Fixed by brave/brave-core#6942
Closed

update links from Crypto.com #12304

rebron opened this issue Oct 23, 2020 · 2 comments · Fixed by brave/brave-core#6942
Assignees
@ryanml
Labels
feature/widgets OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/exclude
Milestone
1.16.x - Release #1

Comments

@rebron
Copy link
Collaborator

rebron commented Oct 23, 2020 •
edited
Loading

Description

Update links from Crypto.com

Steps to Reproduce

  1. Go to NTP and select Crypto.com widget
  2. Clickthrough the links on initial widget screen (buy button top and bottom) and crypto details (buy and supported pairs button)
  3. Links should reflect location of where the user clicked from.

Actual result:

See expected result. The first Initial Widget State link is correct. The three renaming need to be updated.

Expected result:

Screen Shot 2020-10-23 at 1 08 04 PM

Initial Widget State - Buy Button (top):
https://auth.crypto.com/exchange/signup?utm_source=Brave&utm_medium=Trading%20Widget&utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_InitialWidgetState_BuyButton_Top&utm_content=MVP_InitialWidgetState_BuyButton_Top

Initial Widget State - Buy Bitcoin Button (bottom):
https://auth.crypto.com/exchange/signup?utm_source=Brave&utm_medium=Trading%20Widget&utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_InitialWidgetState_BuyButton_Bottom&utm_content=MVP_InitialWidgetState_BuyButton_Bottom

Screen Shot 2020-10-23 at 1 07 40 PM

Crypto Details - Buy Button (top):
https://auth.crypto.com/exchange/signup?utm_source=Brave&utm_medium=Trading%20Widget&utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_CryptoDetails_BuyButton_Top&utm_content=MVP_CryptoDetails_BuyButton_Top

Crypto Details - Pair Name (dynamic value for pair name)
https://auth.crypto.com/exchange/signup?utm_source=Brave&utm_medium=Trading-Widget&utm_campaign=Brave:WW-en:Trading-Widget_MVP_CryptoDetails_{pairname}&utm_content=MVP_CryptoDetails_{pairname}
Example: {pairname} is replaced by BTC_USDT

Reproduces how often:

Easily.

Desktop Brave version:

1.16.67

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/aa

Miscellaneous Information:
@kjozwiak kjozwiak added this to the 1.16.x - Release milestone Oct 23, 2020
@kjozwiak
Copy link
Member

Adding release/blocking and moved into the 1.16.x milestone as we want this released with 1.16.x.

ryanml added a commit to brave/brave-core that referenced this issue Oct 23, 2020
@ryanml
Fixes brave/brave-browser#12304 - Updates Top buy link in asset detai…
21bf8e2 
…l view [crypto.com widget]
@ryanml ryanml mentioned this issue Oct 23, 2020
Merged
33 tasks
This was referenced Oct 24, 2020
Merged
Merged
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 26, 2020 •
edited by srirambv
Loading

Verification passed on


Brave | 1.16.68 Chromium: 86.0.4240.111 (Official Build) (64-bit)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | Windows 10 OS Version 1903 (Build 18362.1139)

Note: Cleared cookies/data before clicking each link

Initial Widget State - Buy Button (top):

https://auth.crypto.com/users/sign_up?utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_InitialWidgetState_BuyButton_Top&utm_content=MVP_InitialWidgetState_BuyButton_Top&utm_medium=Trading+Widget&utm_source=Brave

Initial Widget State - Buy Bitcoin Button (bottom):

https://auth.crypto.com/users/sign_up?utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_InitialWidgetState_BuyButton_Bottom&utm_content=MVP_InitialWidgetState_BuyButton_Bottom&utm_medium=Trading+Widget&utm_source=Brave

Crypto Details - Buy Button (top):
https://auth.crypto.com/users/sign_up?utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_CryptoDetails_BuyButton_Top&utm_content=MVP_CryptoDetails_BuyButton_Top&utm_medium=Trading+Widget&utm_source=Brave

Crypto Details - Pair Name (dynamic value for pair name)

https://auth.crypto.com/users/sign_up?utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_CryptoDetails_BTC%2FUSDT&utm_content=MVP_CryptoDetails_BTC%2FUSDT&utm_medium=Trading-Widget&utm_source=Brave

Verification passed on

Brave 1.16.68 Chromium: 86.0.4240.111 (Official Build) (x86_64)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS macOS Version 10.15.7 (Build 19H2) 
https://auth.crypto.com/users/sign_up?utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_InitialWidgetState_BuyButton_Top&utm_content=MVP_InitialWidgetState_BuyButton_Top&utm_medium=Trading+Widget&utm_source=Brave
  • Initial Widget State - Buy Bitcoin Button (bottom) link is updated to
https://auth.crypto.com/users/sign_up?utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_InitialWidgetState_BuyButton_Bottom&utm_content=MVP_InitialWidgetState_BuyButton_Bottom&utm_medium=Trading+Widget&utm_source=Brave
  • Token Details - Buy Button (top) link is updated to
https://auth.crypto.com/users/sign_up?utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_CryptoDetails_BuyButton_Top&utm_content=MVP_CryptoDetails_BuyButton_Top&utm_medium=Trading+Widget&utm_source=Brave
  • Trading Pair button link is updated to
https://auth.crypto.com/users/sign_up?utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_CryptoDetails_BTC%2FUSDT&utm_content=MVP_CryptoDetails_BTC%2FUSDT&utm_medium=Trading-Widget&utm_source=Brave

Verification passed on

Brave 1.16.68 Chromium: 86.0.4240.111 (Official Build) (64 Bit)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS Linux 
https://auth.crypto.com/users/sign_up?utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_InitialWidgetState_BuyButton_Top&utm_content=MVP_InitialWidgetState_BuyButton_Top&utm_medium=Trading+Widget&utm_source=Brave
  • Initial Widget State - Buy Bitcoin Button (bottom) link is updated to
https://auth.crypto.com/users/sign_up?utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_InitialWidgetState_BuyButton_Bottom&utm_content=MVP_InitialWidgetState_BuyButton_Bottom&utm_medium=Trading+Widget&utm_source=Brave
  • Token Details - Buy Button (top) link is updated to
https://auth.crypto.com/users/sign_up?utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_CryptoDetails_BuyButton_Top&utm_content=MVP_CryptoDetails_BuyButton_Top&utm_medium=Trading+Widget&utm_source=Brave
  • Trading Pair button link is updated to
https://auth.crypto.com/users/sign_up?utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_CryptoDetails_BTC%2FUSDT&utm_content=MVP_CryptoDetails_BTC%2FUSDT&utm_medium=Trading-Widget&utm_source=Brave

@rebron rebron changed the title [Desktop] update links from Crypto.com update links from Crypto.com Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/widgets OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/exclude
Projects
None yet
Milestone
1.16.x - Release #1
Development

Successfully merging a pull request may close this issue.

Removing back arrow in asset detail view, updating top buy link [crypto.com widget] brave/brave-core
5 participants
@kjozwiak @rebron @ryanml @srirambv @GeetaSarvadnya