Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions requests should be cancelled when closing a locked connection window #11764

Closed
ryanml opened this issue Sep 18, 2020 · 1 comment · Fixed by brave/ethereum-remote-client#177

Comments

@ryanml
Copy link
Contributor

ryanml commented Sep 18, 2020

Original video of the issue:
web3-close-bug

Test Plan

  1. Setup Crypto Wallets
  2. Lock the wallet
  3. Navigate to a dapp such as cryptokitties.co
  4. Click "Start" to connect your wallet
  5. Close the popup window without entering your password

Actual

  1. You are unable to connect again, seeing errors in the web console

Expected

  1. You can open another connection window and connect after unlocking your wallet via the popup
@ryanml ryanml self-assigned this Sep 18, 2020
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Sep 18, 2020
@ryanml ryanml added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 18, 2020
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.16.68 Chromium: 86.0.4240.111 (Official Build) (64-bit)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS Linux
Component 1.0.16 dev
  • Verified permission request is only prompted once when closing a locked connection window

Verification passed on

Brave 1.17.50 Chromium: 86.0.4240.111 (Official Build) dev (64-bit)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS Windows 10 OS Version 1809 (Build 17763.1518)
Component 1.0.16 dev
  • Verified permission request is only prompted once when closing a locked connection window

Verification passed on

Brave 1.18.5 Chromium: 86.0.4240.111 (Official Build) nightly (x86_64)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS macOS Version 10.15.7 (Build 19H2)
Component 1.0.16 dev
  • Verified permission request is only prompted once when closing a locked connection window

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment