Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoplay allowed but URL bar still reads autoplay blocked #1120

Closed
LaurenWags opened this issue Sep 13, 2018 · 2 comments · Fixed by brave/brave-core#520
Closed

autoplay allowed but URL bar still reads autoplay blocked #1120

LaurenWags opened this issue Sep 13, 2018 · 2 comments · Fixed by brave/brave-core#520

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Sep 13, 2018

Description

When attempting to view an .mp4 file on Google Drive, even if Autoplay is enabled URL bar still says Autoplay blocked. Disabling shields and attempting to play the video does not allow video to be played and console shows errors.

Steps to Reproduce

  1. Clean profile 0.55.3
  2. Login to Google Drive
  3. Attempt to play an .mp4 file --> see notification in URL bar about autoplay being blocked.
  4. Click on this and choose to Always Allow, video still will not play (Google Drive does not play mp4 video #1122), console errors.
  5. Put shields down, video still will not play, console errors.

Actual result:

Autoplay is blocked even if allowed, video will not play (shields up or down):
screen shot 2018-09-13 at 12 52 59 pm

console errors: https://gist.github.com/LaurenWags/bda1b03eaeda8a3b8060b68cfd01ff8b#file-autoplay-txt

Expected result:

Autoplay should not be blocked, video should play, no console errors.

Reproduces how often:

easily

Brave version (chrome://version info)

Brave | 0.55.3 Chromium: 70.0.3538.12 (Official Build) dev (64-bit)
Revision | ad61584ca32115f953ce656dd75b44f1c502a75d-refs/branch-heads/3538@{#179}
OS | Mac OS X

Reproducible on current release:

no, does not reproduce on 0.23.107

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? no
  • Is the issue reproducible on the latest version of Chrome? no

Additional Information

Reproduced by @srirambv on Win.

When playing an .mp4 on photos.google.com there are two requests to allow Autoplay, photos.google.com and then youtube.googleapis.com. When playing a video from drive.google.com you don't get the second request to allow autoplay - maybe related to this issue?

@yrliou
Copy link
Member

yrliou commented Sep 28, 2018

Please see brave/brave-core#520 for the test plan.

@LaurenWags
Copy link
Member Author

LaurenWags commented Oct 9, 2018

Verified passed with

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux

Verification passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment