Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crowd-deny updates #10280

Closed
jumde opened this issue Jun 15, 2020 · 8 comments · Fixed by brave/brave-core#7164
Closed

Fix crowd-deny updates #10280

jumde opened this issue Jun 15, 2020 · 8 comments · Fixed by brave/brave-core#7164
Assignees
Labels
feature/components OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@jumde
Copy link
Contributor

jumde commented Jun 15, 2020

Description

Crowd deny updates/installs fails on latest nightly

Steps to Reproduce

  1. Open Brave Browser with new profile
  2. Navigate to brave://components
  3. Check crowd deny

Actual result:

Crowd deny doesn't update

Expected result:

Crowd deny should update

Reproduces how often:

Easily

Brave version (brave://version info)

1.12.25 Chromium: 83.0.4103.97

Version/Channel Information:

Nightly

@jumde jumde self-assigned this Jun 15, 2020
@rebron
Copy link
Collaborator

rebron commented Aug 7, 2020

@jumde is this still an issue? I checked 1.12.108 and latest nightly and it looks like Crowd Deny updates when I manually select check for update.

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 11, 2020
@jumde jumde changed the title [Desktop] Fix crow-deny updates [Desktop] Fix crowd-deny updates Nov 25, 2020
@mherrmann
Copy link

@rebron I think the problem appears on automatic updates when you navigate to brave://components and wait for 60 seconds. See #10464.

@mherrmann
Copy link

@jumde in current versions of Brave, Crowd Deny is not installed. (It's only registered, then remains at 0.0.0.0 forever until a user happens to "check for an update" for this particular component.) Per #8709, I would remove Crowd Deny from brave://components. Do you agree with this?

@jumde
Copy link
Contributor Author

jumde commented Jan 7, 2021

@mihaiplesa @mherrmann - As I understand Crowd Deny is not fixed given it is in the list of blacklisted components - https://github.com/brave/brave-core/blob/5709a5804cf3c0f3f96e6c250fcb34c666d75717/chromium_src/components/component_updater/component_installer.cc#L26 - Can we re-open this issue?

@mherrmann
Copy link

@jumde it depends what you mean by "fixed". Per my comment above I've added Crowd Deny to the list of blacklisted components to remove it. This "fixes" this issue in the sense that there is no longer an update error for crowd deny. But from what you wrote, it does not sound like that is the meaning of "fixed" you intended.

@mherrmann
Copy link

Further info: #8709 (comment)

@jumde
Copy link
Contributor Author

jumde commented Jan 7, 2021

I created a new issue to enable the component: #13426

@LaurenWags
Copy link
Member

Labeling as QA/Blocked - questions sent to @jumde 👍🏻

@rebron rebron changed the title [Desktop] Fix crowd-deny updates Fix crowd-deny updates Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/components OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants