Fix linking error and add unit tests #67

tmancey · 2019-02-11T14:00:38Z

fixes #59
fixes #60

emerick

LGTM

emerick · 2019-02-11T17:41:26Z

src/confirmations_impl.cc

@@ -285,7 +319,7 @@ std::map<std::string, std::string> ConfirmationsImpl::GetCatalogIssuers()
 }

 bool ConfirmationsImpl::IsValidPublicKeyForCatalogIssues(


Nitpick: Is that a typo in the method name (Issues vs. Issuers)?

That is a typo 👍

…sting

riastradh-brave

Small nit about unit tests, not critical; otherwise OK.

riastradh-brave · 2019-02-15T05:18:52Z

test/confirmations_create_confirmation_request_unittest.cc

+    delete request_;
+
+    delete confirmations_;
+    delete mock_confirmations_client_;


Any particular reason not to use std::unique_ptr for these, so you can skip the explicit deletes?

bridiver · 2019-02-15T17:06:59Z

BUILD.gn

+    ":*",
+    rebase_path("bat-native-ledger", dep_base) + ":*",
+    "//brave/test:*",
+  ]

  sources = [
    "src/bat/confirmations/notification_info.cc",


header files need to be included here as well

bridiver · 2019-02-15T17:08:15Z

src/confirmations_impl.cc


-  UpdateConfirmationsIsReadyStatus();
+  NotifyAdsIfConfirmationsIsReady();


naming convention for this would be MaybeNotifyConfirmationsIsReady

MaybeNotifyConfirmationsIsReady does not seem right to me either as not using observer pattern, what about UpdateConfirmationsStatus until this code can be refactored to use observers?

bridiver · 2019-02-15T17:09:06Z

src/confirmations_impl.h

@@ -17,11 +17,13 @@
 #include "refill_tokens.h"
 #include "redeem_token.h"
 #include "payout_tokens.h"
+#include "unblinded_tokens.h"


why do we have a header include and a forward decl? Looks like only the forward decl is needed

bridiver · 2019-02-15T17:10:56Z

src/create_confirmation_request.cc

+
+namespace confirmations {
+
+CreateConfirmationRequest::CreateConfirmationRequest() = default;


convention here would be ConfirmationRequestBuilder or just ConfirmationRequest

CreateConfirmationRequest is due to the server API naming the task CreateConfirmation as the API creates a confirmation

Right now these classes do not follow the builder design pattern where we could return a request object which can then also be unit tested

bridiver · 2019-02-15T17:12:35Z

src/create_confirmation_request.cc

@@ -0,0 +1,112 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public


we should really avoid this pattern of putting everything in the src root, it's going to cause issues with conflicting header include paths.

Totally agree as we discussed before, can we do this after 1.0 as we need to do this across all native libs?

bridiver · 2019-02-15T17:13:12Z

src/fetch_payment_token_request.cc

+
+namespace confirmations {
+
+FetchPaymentTokenRequest::FetchPaymentTokenRequest() = default;


PaymentTokenRequestBuilder or just PaymentTokenRequest

FetchPaymentTokenRequest is due to the server API naming the task FetchPaymentToken as the API fetches a payment token

I see, but the convention in chromium is still to use *Builder for stuff like this

it seems a little unnecessary to even instantiate this in its current form since all the state is transient. I think we either want a Builder pattern with set_confirmation_id and maybe set_endpoint_version (default to 1) or just make them static and dump the class

bridiver · 2019-02-15T17:14:10Z

src/request_signed_tokens_request.cc

+
+namespace confirmations {
+
+RequestSignedTokensRequest::RequestSignedTokensRequest() = default;


see above builder naming convention

Same as above, the API requests a signed token

bridiver · 2019-02-15T20:55:25Z

test/confirmations_create_confirmation_request_unittest.cc

+#include <string>
+
+#include "confirmations_client_mock.h"
+#include "brave/vendor/bat-native-confirmations/src/confirmations_impl.h"


We shouldn't be using header paths like this, it indicates a problem with the include_dirs in the config. We should expose the internal-config to tests so they can access these files using the correct paths

actually I already did that so not sure how these paths came back

these paths came back as part of unit tests and I used an older template for the unit tests, let me fix these issues

bridiver · 2019-02-15T20:59:09Z

src/redeem_token.cc


-  confirmations_client_->URLRequest(ads_serve_url, {}, "", "",
-      URLRequestMethod::GET, callback);
+  confirmations_client_->LoadURL(url, {}, "", "", method, callback);
 }

 void RedeemToken::OnFetchPaymentToken(


this method is huge and should be broken up, but it also has no tests that I can see which is scary given how big it is

This method is 16 lines long? There are currently no tests for URL requests and parsing of the JSON from server responses. I will decouple the JSON parsing code and add further unit tests.

am I misreading something? Starts at line 188 and ends at line 341?

sometimes I miss collapsed code in the diff, but I looked again and don't see a method ending that I missed

This reverts commit 35f055e.

tmancey and others added 2 commits February 10, 2019 15:54

Decoupled unblinded tokens and url request builder for unit tests

4b98c9f

refactor dependencies

62cbf54

tmancey self-assigned this Feb 11, 2019

tmancey requested review from bridiver, emerick and evq February 11, 2019 14:00

tmancey changed the title ~~Fix linking error terry~~ [WIP Fix linking error terry Feb 11, 2019

tmancey changed the title ~~[WIP Fix linking error terry~~ [WIP] Fix linking error and merge latest changes Feb 11, 2019

emerick previously approved these changes Feb 11, 2019

View reviewed changes

tmancey dismissed emerick’s stale review via c2514f5 February 11, 2019 21:29

tmancey force-pushed the fix-linking-error-terry branch 8 times, most recently from a9bdaab to 760af7d Compare February 12, 2019 15:59

tmancey added 2 commits February 12, 2019 16:24

Resolve compiler errors and decouple logic in preparation for unit te…

52cdd8f

…sting

Added unit tests

fba436f

tmancey force-pushed the fix-linking-error-terry branch from 760af7d to fba436f Compare February 12, 2019 16:24

tmancey changed the title ~~[WIP] Fix linking error and merge latest changes~~ Fix linking error and add unit tests Feb 12, 2019

This was referenced Feb 12, 2019

Ads Confirmations brave/brave-core#1645

Merged

Add unit tests #59

Closed

tmancey added 3 commits February 13, 2019 17:39

Fix build for Windows/Linux

94a7b33

Fix linter errors

943cf10

Confirmations should not be initialized if the wallet is invalid

5790f84

riastradh-brave previously approved these changes Feb 15, 2019

View reviewed changes

Removed unecessary boolean logic

3152c6c

tmancey dismissed riastradh-brave’s stale review via 3152c6c February 15, 2019 10:40

Return if wallet info is not ready

2d0765a

bridiver reviewed Feb 15, 2019

View reviewed changes

tmancey and others added 12 commits February 15, 2019 23:38

Fix build error

0915715

Fix header files

1e4836e

Fix unit tests

5b4688e

Remove redundant #include for unblinded_tokens.h

35f055e

Fixed unit test #include paths

c3fd538

Revert "Remove redundant #include for unblinded_tokens.h"

b1a2b2d

This reverts commit 35f055e.

Remove redundant #include for unblinded_tokens.h

210476d

Fixed unit test #include paths

5c03863

Refactor new to unique_ptr for unit tests

e7cac13

Remove logging for unit tests

5666f7c

Resolved lint error

1718db5

Added README.md

ea09271

tmancey force-pushed the fix-linking-error-terry branch from f665e89 to ea09271 Compare February 17, 2019 12:49

tmancey mentioned this pull request Feb 18, 2019

Ads Confirmations brave/brave-browser#3406

Merged

16 tasks

Fixed linter errors

eaa9154

bridiver approved these changes Feb 19, 2019

View reviewed changes

tmancey merged commit 74fee31 into master Feb 19, 2019

tmancey deleted the fix-linking-error-terry branch February 19, 2019 01:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix linking error and add unit tests #67

Fix linking error and add unit tests #67

tmancey commented Feb 11, 2019 •

edited

Loading

emerick left a comment

emerick Feb 11, 2019

tmancey Feb 12, 2019

riastradh-brave left a comment

riastradh-brave Feb 15, 2019

tmancey Feb 16, 2019 •

edited

Loading

bridiver Feb 15, 2019

tmancey Feb 16, 2019

bridiver Feb 15, 2019

tmancey Feb 16, 2019 •

edited

Loading

bridiver Feb 15, 2019

tmancey Feb 16, 2019

bridiver Feb 15, 2019

tmancey Feb 16, 2019

tmancey Feb 16, 2019 •

edited

Loading

bridiver Feb 15, 2019

tmancey Feb 15, 2019

bridiver Feb 15, 2019

tmancey Feb 15, 2019 •

edited

Loading

bridiver Feb 17, 2019

bridiver Feb 17, 2019

bridiver Feb 15, 2019

tmancey Feb 15, 2019

bridiver Feb 15, 2019

bridiver Feb 15, 2019

tmancey Feb 15, 2019

tmancey Feb 16, 2019

bridiver Feb 15, 2019

tmancey Feb 15, 2019 •

edited

Loading

bridiver Feb 17, 2019

bridiver Feb 17, 2019

		@@ -285,7 +319,7 @@ std::map<std::string, std::string> ConfirmationsImpl::GetCatalogIssuers()
		}

		bool ConfirmationsImpl::IsValidPublicKeyForCatalogIssues(


		UpdateConfirmationsIsReadyStatus();
		NotifyAdsIfConfirmationsIsReady();


		namespace confirmations {

		CreateConfirmationRequest::CreateConfirmationRequest() = default;

		@@ -0,0 +1,112 @@
		/* This Source Code Form is subject to the terms of the Mozilla Public


		namespace confirmations {

		FetchPaymentTokenRequest::FetchPaymentTokenRequest() = default;


		namespace confirmations {

		RequestSignedTokensRequest::RequestSignedTokensRequest() = default;

Fix linking error and add unit tests #67

Fix linking error and add unit tests #67

Conversation

tmancey commented Feb 11, 2019 • edited Loading

emerick left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riastradh-brave left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tmancey Feb 16, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tmancey Feb 16, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tmancey Feb 16, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tmancey Feb 15, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tmancey Feb 15, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tmancey commented Feb 11, 2019 •

edited

Loading

tmancey Feb 16, 2019 •

edited

Loading

tmancey Feb 16, 2019 •

edited

Loading

tmancey Feb 16, 2019 •

edited

Loading

tmancey Feb 15, 2019 •

edited

Loading

tmancey Feb 15, 2019 •

edited

Loading