Handle null chunk type using enum value #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- Trying to narrow down perf loss in .NET 8 compared to .NET 6 specific to stream decompression. Modifications ------------- Rather than using a `Nullable<ChunkType>` to track when the chunk type is unknown, add an enum value that represents null. Results ------- BenchmarkDotNet v0.13.10, Windows 11 (10.0.22621.2861/22H2/2022Update/SunValley2) 12th Gen Intel Core i7-1270P, 1 CPU, 16 logical and 12 physical cores .NET SDK 8.0.100 [Host] : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2 Job-AODULB : .NET Framework 4.8.1 (4.8.9181.0), X64 RyuJIT VectorSize=256 Job-AZPVRO : .NET Framework 4.8.1 (4.8.9181.0), X64 RyuJIT VectorSize=256 Job-FTJSLO : .NET 6.0.25 (6.0.2523.51912), X64 RyuJIT AVX2 Job-XMQQAK : .NET 6.0.25 (6.0.2523.51912), X64 RyuJIT AVX2 Job-IPTUCK : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2 Job-YAGJLP : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2 Job-DJZUQL : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2 Job-FFPERJ : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2 | Method | Runtime | BuildConfiguration | PGO | ReadSize | Mean | Error | StdDev | Ratio | Rank | |----------- |------------------- |------------------- |---- |--------- |---------:|--------:|--------:|------:|-----:| | Decompress | .NET Framework 4.8 | Previous | N | 16384 | 340.4 us | 2.56 us | 2.39 us | 1.00 | 2 | | Decompress | .NET Framework 4.8 | Default | N | 16384 | 332.2 us | 2.64 us | 2.34 us | 0.98 | 1 | | | | | | | | | | | | | Decompress | .NET 6.0 | Previous | N | 16384 | 167.5 us | 1.11 us | 1.04 us | 1.00 | 1 | | Decompress | .NET 6.0 | Default | N | 16384 | 167.5 us | 2.44 us | 2.16 us | 1.00 | 1 | | | | | | | | | | | | | Decompress | .NET 8.0 | Previous | N | 16384 | 200.7 us | 1.19 us | 1.06 us | 1.00 | 2 | | Decompress | .NET 8.0 | Default | N | 16384 | 191.7 us | 1.47 us | 1.30 us | 0.96 | 1 | | | | | | | | | | | | | Decompress | .NET 8.0 | Previous | Y | 16384 | 199.1 us | 0.94 us | 0.88 us | 1.00 | 2 | | Decompress | .NET 8.0 | Default | Y | 16384 | 189.9 us | 0.91 us | 0.85 us | 0.95 | 1 | Note: Benchmarks include other improvements since 1.1.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Trying to narrow down perf loss in .NET 8 compared to .NET 6 specific to stream decompression.
Modifications
Rather than using a
Nullable<ChunkType>to track when the chunk type is unknown, add an enum value that represents null.Results
BenchmarkDotNet v0.13.10, Windows 11 (10.0.22621.2861/22H2/2022Update/SunValley2) 12th Gen Intel Core i7-1270P, 1 CPU, 16 logical and 12 physical cores .NET SDK 8.0.100
[Host] : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2
Job-AODULB : .NET Framework 4.8.1 (4.8.9181.0), X64 RyuJIT VectorSize=256
Job-AZPVRO : .NET Framework 4.8.1 (4.8.9181.0), X64 RyuJIT VectorSize=256
Job-FTJSLO : .NET 6.0.25 (6.0.2523.51912), X64 RyuJIT AVX2
Job-XMQQAK : .NET 6.0.25 (6.0.2523.51912), X64 RyuJIT AVX2
Job-IPTUCK : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2
Job-YAGJLP : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2
Job-DJZUQL : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2
Job-FFPERJ : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2
Note: Benchmarks include other improvements since 1.1.3