Snappy decompression will fail on certain sequence of bytes. #88
Comments
brantburnett
pushed a commit
that referenced
this issue
Jan 14, 2024
Motivation ---------- In cases where the stream decompression block read hits with a start point within the middle of a tag but then the literal is longer than the entire block available we are incorrectly handling the _lookbackPosition when we return. Modifications ------------- Refactor the handling to be a bit less confusing and correct the result. Add a test for the failure case. Fixes #88
|
Thanks for the repro, I believe I have the fix figured out. For general reference, the problem was specific to stream decompression with very long literal segments. Block decompression should have been unaffected. |
Awesome! Thanks for the quick reaction. |
brantburnett
added a commit
that referenced
this issue
Jan 15, 2024
Motivation ---------- In cases where the stream decompression block read hits with a start point within the middle of a tag but then the literal is longer than the entire block available we are incorrectly handling the _lookbackPosition when we return. Modifications ------------- Refactor the handling to be a bit less confusing and correct the result. Add a test for the failure case. Fixes #88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using a certain sequence of bytes decompression will fail with
System.IO.InvalidDataException: 'Invalid copy offset'I have made a PR demonstrating this here:
#87
The text was updated successfully, but these errors were encountered: