Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renable nested title additions and amend test with frontmatter #2

Open
wants to merge 1 commit into
base: title_frontmatter
Choose a base branch
from

Conversation

seam345
Copy link

@seam345 seam345 commented Apr 16, 2023

The frontmatter changes broke the add_titles test

I haven't fully understood the changes you made but going purely off the test I assume you would prefer the result to be

---
title: Main note
---

# Main note

# Sub note

# Sub sub note

No more notes

instead of

---
title: Main note
---

No more notes

So I have made the code changes to achieve this and updated the expected test result

Btw the input file is this

Hope I understood your goal right, I'm just currently attempting to follow in your footsteps to publish a section of my obsidian vault but trying to codify your steps with a Nix file and building a Rust packages in nix requires all tests to pass :D

@seam345
Copy link
Author

seam345 commented Apr 16, 2023

Oh I see this is making use of the --add-titles argument, would you prefer instead of overriding the current --add-titles we could add an --add-frontmatter-titles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant