Fix wrong postgres type for SqlInt64 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about that! The last PR seemed to break CI and I didn't notice. Can you rebase against master? |
added 2 commits
September 27, 2021 18:21
Solution taken from brandonchinn178#75 Author: kaldonir <[email protected]> Date: Wed Jun 2 17:17:39 2021 +0200
|
@brandonchinn178 rebased! 👍 |
|
@brandonchinn178 great, this worked and everything is green. Thank you. After you merged, what do you think when will the next release hit hackage? |
Comment on lines
+3
to
+7
| {-# LANGUAGE DataKinds #-} | ||
| {-# LANGUAGE DerivingStrategies #-} | ||
| {-# LANGUAGE ExistentialQuantification #-} | ||
| {-# LANGUAGE FlexibleContexts #-} | ||
| {-# LANGUAGE FlexibleInstances #-} |
There was a problem hiding this comment.
just checked. Yes, they are still needed.
There was a problem hiding this comment.
oh i see. i'm not running CI on the latest GHC version
|
Looks great! After merging, I can get a release up to Hackage shortly! Can you also add an entry to the CHANGELOG? |
|
actually, never mind about the CHANGELOG. I'll do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #75
I am not sure if the unit test fixes are correct, as i don't see how to run them locally without failing, as they even do fail on master. I tried best effort, welcoming comments on that.
cc @kaldonir @brandonchinn178