Fix even more fallout of bazelbuild@f7eee1e .

RELNOTES: None. PiperOrigin-RevId: 261161639
brandjon · Aug 1, 2019 · 90a55a9 · 90a55a9
1 parent 574153b
commit 90a55a9
Showing 1 changed file with 21 additions and 6 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/actions/FileArtifactValue.java b/src/main/java/com/google/devtools/build/lib/actions/FileArtifactValue.java
@@ -478,14 +478,22 @@ public long getModifiedTime() {
     @Override
     public String toString() {
       return MoreObjects.toStringHelper(this)
-          .add("digest", BaseEncoding.base16().lowerCase().encode(digest))
+          .add(
+              "digest",
+              digest == null ? "(null)" : BaseEncoding.base16().lowerCase().encode(digest))
           .add("size", size)
           .add("proxy", proxy)
           .toString();
     }
 
     @Override
     public boolean couldBeModifiedSince(FileArtifactValue o) {
+      if (digest != null && o.getDigest() != null) {
+        // TODO(lberki): This sometimes compares between RemoteFileArtifactValue and
+        // RegularFileArtifactValue. Pretty unintuitive, that.
+        return !Arrays.equals(digest, o.getDigest()) || getSize() != o.getSize();
+      }
+
       if (!(o instanceof RegularFileArtifactValue)) {
         return true;
       }
@@ -495,11 +503,7 @@ public boolean couldBeModifiedSince(FileArtifactValue o) {
         return true;
       }
 
-      if (digest != null && lastKnown.digest != null) {
-        return !Arrays.equals(digest, lastKnown.digest);
-      } else {
-        return !Objects.equals(proxy, lastKnown.proxy);
-      }
+      return !Objects.equals(proxy, lastKnown.proxy);
     }
 
     @Override
@@ -564,6 +568,17 @@ public FileContentsProxy getContentsProxy() {
       throw new UnsupportedOperationException();
     }
 
+    @Override
+    public boolean couldBeModifiedSince(FileArtifactValue o) {
+      if (digest != null && o.getDigest() != null) {
+        // TODO(lberki): This sometimes compares between RemoteFileArtifactValue and
+        // RegularFileArtifactValue. Pretty unintuitive, that.
+        return !Arrays.equals(digest, o.getDigest()) || getSize() != o.getSize();
+      }
+
+      return true;
+    }
+
     @Override
     public long getSize() {
       return size;