Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ENG-5789 - Version pin xcproj and cocoapods for CI #2763

Merged
merged 5 commits into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/cli/src/actions/packagers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,14 @@ export default defineAction(async (): Promise<void> => {
*/
if (canRunIOS(config.options)) {
try {
for await (const line of execa({
const podInstallOut = execa({
cwd: path.project.resolve('ios'),
})`pod install`) {
})(
isCI ? 'bundle' : 'pod',
isCI ? ['exec', 'pod', 'install'] : ['install'],
);

for await (const line of podInstallOut) {
logger.debug(line);
}

Expand Down
6 changes: 3 additions & 3 deletions packages/cli/templates/react-native-0.72/addons/ios/Gemfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
source "https://rubygems.org"

# Cocoapods 1.15 introduced a bug which break the build. We will remove the upper
# bound in the template on Cocoapods with next React Native release.
gem 'cocoapods', '>= 1.13', '< 1.15'
# Cocoapods 1.16 requires xcodeproj 1.26.0, which is not compatible with React Native due to a bug.
gem 'cocoapods', '~> 1.15.0'
gem 'activesupport', '>= 6.1.7.5', '< 7.1.0'
gem 'xcodeproj', '~> 1.25.0'
6 changes: 3 additions & 3 deletions packages/cli/templates/react-native-0.73/addons/ios/Gemfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
source "https://rubygems.org"

# Cocoapods 1.15 introduced a bug which break the build. We will remove the upper
# bound in the template on Cocoapods with next React Native release.
gem 'cocoapods', '>= 1.13', '< 1.15'
# Cocoapods 1.16 requires xcodeproj 1.26.0, which is not compatible with React Native due to a bug.
gem 'cocoapods', '~> 1.15.0'
gem 'activesupport', '>= 6.1.7.5', '< 7.1.0'
gem 'xcodeproj', '~> 1.25.0'