Skip to content

Commit

Permalink
fix: version pin cocoapods and xcodeproj, ensure pod install is exec …
Browse files Browse the repository at this point in the history
…through bundle to force gems.
  • Loading branch information
UncleClapton committed Oct 29, 2024
1 parent d06379f commit 67b598e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion packages/cli/src/actions/packagers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export default defineAction(async (): Promise<void> => {
try {
for await (const line of execa({
cwd: path.project.resolve('ios'),
})`pod install`) {
})(isCI ? 'bundle exec pod install' : 'pod install')) {
logger.debug(line);
}

Expand Down
6 changes: 3 additions & 3 deletions packages/cli/templates/react-native-0.72/addons/ios/Gemfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
source "https://rubygems.org"

# Cocoapods 1.15 introduced a bug which break the build. We will remove the upper
# bound in the template on Cocoapods with next React Native release.
gem 'cocoapods', '>= 1.13', '< 1.15'
# Cocoapods 1.16 requires xcodeproj 1.26.0, which is not compatible with React Native due to a bug.
gem 'cocoapods', '>= 1.13', '< 1.16'
gem 'activesupport', '>= 6.1.7.5', '< 7.1.0'
gem 'xcodeproj', '< 1.26.0'
6 changes: 3 additions & 3 deletions packages/cli/templates/react-native-0.73/addons/ios/Gemfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
source "https://rubygems.org"

# Cocoapods 1.15 introduced a bug which break the build. We will remove the upper
# bound in the template on Cocoapods with next React Native release.
gem 'cocoapods', '>= 1.13', '< 1.15'
# Cocoapods 1.16 requires xcodeproj 1.26.0, which is not compatible with React Native due to a bug.
gem 'cocoapods', '>= 1.13', '< 1.16'
gem 'activesupport', '>= 6.1.7.5', '< 7.1.0'
gem 'xcodeproj', '< 1.26.0'

0 comments on commit 67b598e

Please sign in to comment.