#2045 remove this check #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,9 +16,6 @@ function dataIsEmpty( data ) | |||
| if ( !data) | |||
| return true; | |||
|
|
|||
| if ( data.length > 20 ) | |||
| return false; | |||
|
|
|||
| var value = data.replace( /[\n|\t]*/g, '' ).toLowerCase(); | |||
| if ( !value || value == '<br>' || value == '<p> <br></p>' || value == '<p><br></p>' || value == '<p> </p>' || value == ' ' || value == ' ' || value == ' <br>' || value == ' <br>' || value == '<p class="fs-14"><br></p>' || value == '<p class="fs-14"> <br></p>') | |||
There was a problem hiding this comment.
Please can we refactor this?
var _ = require('lodash');
var matches = ['<br>', '<p> <br></p>', '<p><br></p>', '<p> </p>', ' ', ' ', ' <br>', ' <br>', '<p class="fs-14"><br></p>', '<p class="fs-14"> <br></p>'];
if(!value || _.includes(matches, value) {
return true;
}
There was a problem hiding this comment.
@nodesocket We’re trying to limit our changes. This is the ckeditor source, which, sadly, we’ve had to fork, but we still want to maintain the minimal surface area of local modifications.
There was a problem hiding this comment.
Sure. Though their code makes me throw up a little in my mouth 😷 . Shouldn't it also be catching <br />?
There was a problem hiding this comment.
It's actually community driven code. This plugin isn't something they have written.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially fixes ckeditor#2045