Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Move to go mods #43

Merged
merged 2 commits into from
Jun 13, 2019
Merged

*: Move to go mods #43

merged 2 commits into from
Jun 13, 2019

Conversation

brancz
Copy link
Owner

@brancz brancz commented Jun 13, 2019

While working on a few things go mods were a bit in my way (or rather the lack thereof), so I decided to just go ahead and make the switch.

@s-urbaniak @metalmatze @paulfantom @squat

@metalmatze
Copy link
Collaborator

You probably want to set GO111MODULE=on inside the Makefile for the go build command, at least until its enabled by default in Go 1.13.

@brancz
Copy link
Owner Author

brancz commented Jun 13, 2019

@metalmatze I split it into two commits now, so it's easier to see. I already set the env variable in .travis.yml. Once it's the default, we won't need to set it anymore, which is why I didn't want it to be in the makefile itself.

Copy link
Collaborator

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brancz brancz merged commit 1b6a19f into master Jun 13, 2019
@brancz brancz deleted the gomods branch June 13, 2019 11:58
s-urbaniak pushed a commit to s-urbaniak/kube-rbac-proxy that referenced this pull request Apr 28, 2021
add hardcoded authorizer to approve /metrics for metrics scraper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants