Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added profile for Shelly EM #2903

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

michalk-k
Copy link
Contributor

Device information

Home Assistant Device information

Checklist

  • I have created a single PR per device. When you have multiple submissions please create separate PR's.
  • For lights - I have only included the gzipped files (*.gz), not the raw CSV files.
  • For lights - I have provided a CSV file per supported color mode. Look that up in Developer Tools -> States

Additional info

  • I've changed order of attributes, grouping them together by the meaning.
  • I made use of measure_settings even though I was using a manual method (own script scrapping data from measurement device)

profile_library/shelly/Shelly EM/model.json Outdated Show resolved Hide resolved
"only_self_usage": false,
"calculation_strategy": "fixed",
"standby_power": 0.598,
"fixed_config": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the new recommended format as explained for scenarios here:
https://docs.powercalc.nl/library/device-types/smart-switch/#smart-switch-with-built-in-powermeter

So you can use standby_power_on for this and get rid of fixed_config

I will migrate all the other smart switch profiles to this definite profile format soon.

Copy link
Owner

@bramstroker bramstroker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Will merge after 1.17 release.
Will probably release next weekend.

@michalk-k
Copy link
Contributor Author

michalk-k commented Jan 7, 2025

I need to revert only_self_usage to false :)
Your confidence confused me ;)

Shelly EM has 2 measurement clamps, and on top of this, it has a relay not equipped with measurement.
The only_self_usage = false is intended to add fixed/linear energy switched by this switch.

May I add a commit yet to this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants