Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support same alias for multiple manufacturers in library loading code #2852

Merged
merged 9 commits into from
Dec 27, 2024

Conversation

bramstroker
Copy link
Owner

@bramstroker bramstroker commented Dec 26, 2024

  • Implement multi aliases in custom_components.powercalc.power_profile.loader.remote.RemoteLoader.find_manufacturers
  • See if we can use ModelInfo objects in remote loader
  • Improve remote loader code for efficiency. Caching. We are calling same method multiple times during discovery.

Double check local error:

2024-12-26 14:45:37.254 ERROR (MainThread) [custom_components.powercalc.strategy.lut] light.ambient_muur: Lookup table not found for color mode (model: LED1738G7, color_mode: hs)

@github-actions github-actions bot added the enhancement New feature or request label Dec 26, 2024
@bramstroker bramstroker changed the title feat: prepare library loading code for same alias for multiple manufa… Support same alias for multiple manufacturers in library loading code Dec 26, 2024
@bramstroker bramstroker merged commit b5450e1 into master Dec 27, 2024
16 checks passed
@bramstroker bramstroker deleted the feat/multi-manufacturer-aliases branch January 5, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant