Issue/302 invalid time na when using progress listener #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. As we make these changes, there are certainly a few things I don't like about the existing API, such as using -1 to mean N/A. Ideally we split the type to be null/optional/something when N/A, and a real int when otherwise. Thus forcing the call to deal with the N/A, hopefully in a safe way. Maybe we start to make a list for the next major version, that uses the latest and greatest Java. Anyways, this pr looks good. Thanks! |
|
@bramp There are multiple things we already discussed that would be breaking the API. |
Euklios
deleted the
issue/302-invalid-time-NA-when-using-progress-listener
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #302 and adds corresponding tests