Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for input devices/streams and tests #178

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Omar-Riaz
Copy link

I created a subclass called FFMpegInputBuilder which extends the AbstractFFmpegStreamBuilder. Seeing that the AbstractFFmpegInputBuilder was designed for outputs, I re-implemented the filename property and build method to retain all previous functionality.

I also added tests to see that the inputs are built properly, modelled after #156 . I added a convenience method to parse commands separated by spaces for assertion purposes.

From the FFmpegBuilder, you simply call addInputStream(String inputStream) to build the input.

@Omar-Riaz
Copy link
Author

Updated test to support device_number. Is it ok to include the parameter if there are no duplicates and it is set to zero?

@coveralls
Copy link

Coverage Status

Coverage increased (+2.3%) to 84.106% when pulling 3da1165 on Omar-Riaz:master into 3819b15 on bramp:master.

@bramp
Copy link
Owner

bramp commented Aug 27, 2018

Thanks for the PR. I'm on vacation for the next week, so I won't look at this until later next week. Feel free to ping me if I don't respond next week.

@Omar-Riaz
Copy link
Author

Hi @bramp , did you get a chance to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants