Open PayPal App URL if present in BT GW response #1234
Conversation
…perty to check for empty string on token/ba_token query param
scannillo
changed the title
scannillo
changed the title
| var urlComponents = URLComponents(url: paypalAppRedirectUrl, resolvingAgainstBaseURL: true) | ||
| urlComponents?.queryItems = [ | ||
| URLQueryItem(name: "source", value: "braintree_sdk"), | ||
| URLQueryItem(name: "switch_initiated_time", value: String(UInt64(Date().timeIntervalSince1970 * 1000))) |
There was a problem hiding this comment.
Do we want to update this based on the discussion on confluence around adding additional precision?
There was a problem hiding this comment.
Updated! Also using Int instead of UInt64, which I think we only needed when we supported 32 bit devices way back when
Ran some local tests to confirm the rounding looks good:
- 1711390872156.703 --> 1711390872157
- 1711390872661.359 --> 1711390872661
- 1711390873618.973 --> 1711390873619
There was a problem hiding this comment.
We'll also want to make that change in main for our analytics timestamps
There was a problem hiding this comment.
DTBTSDK-3703 - ticket to fix on main
| switch redirectType { | ||
| case .webBrowser(let url), .payPalApp(let url): | ||
| let url = URLComponents(url: url, resolvingAgainstBaseURL: true) | ||
| if let token = url?.queryItems?.first(where: { $0.name == "token" || $0.name == "ba_token" })?.value, |
There was a problem hiding this comment.
General question, is there ever an instance where we'd get both of these params back for the app switch flow but only actually care about 1 of them? Asking because if so we may always want to attempt to parse the ba_token first then if not there move on to the token.
There was a problem hiding this comment.
Yes! We should prioritize the ba_token over the token if both are available. Since this change also needs to be made on main (+ tests added for the priority), I was thinking it could be a separate PR targeting main first, and then handling the merge conflicts when updating this branch. Thoughts?
There was a problem hiding this comment.
Yeah I am fine if we want to target that on main instead of here. The merge conflict may be a bit weird since it'll likely be in the section we removed in this PR, but the tests would help us remember.
| if let urlTimestamp = urlComponents?.queryItems?[1].value { | ||
| XCTAssertNotNil(Int(urlTimestamp)) | ||
| } else { | ||
| XCTFail("Expected integer value for query param `switch_initiated_time`") | ||
| } |
There was a problem hiding this comment.
| if let urlTimestamp = urlComponents?.queryItems?[1].value { | |
| XCTAssertNotNil(Int(urlTimestamp)) | |
| } else { | |
| XCTFail("Expected integer value for query param `switch_initiated_time`") | |
| } | |
| XCTAssertNotNil(Int(urlComponents?.queryItems?[1].value ?? '')) |
🧶 : Take or leave to avoid if statement in the test.
| #endif | ||
|
|
||
| /// The type of PayPal authentication flow to occur | ||
| enum PayPalRedirectType { |
There was a problem hiding this comment.
q: Would it make sense for this enum to be in it's own file?
There was a problem hiding this comment.
I opted to leave in here since it's so small, but down to move if folks feel strongly!
| @@ -4,7 +4,8 @@ import BraintreeCore | |||
| @UIApplicationMain class AppDelegate: UIResponder, UIApplicationDelegate { | |||
|
|
|||
| private let returnURLScheme = "com.braintreepayments.Demo.payments" | |||
| private let universalLinkURL = "https://braintree-ios-demo.fly.dev/braintree-payments" | |||
There was a problem hiding this comment.
q: Is this the domain that hosts the apple-app-site-association file?
There was a problem hiding this comment.
Yes! Our Demo app now has an HTTPS URL registered for it 🎊 - https://braintree-ios-demo.fly.dev/.well-known/apple-app-site-association
There was a problem hiding this comment.
Jax built it out https://github.com/jaxdesmarais/fly-server-demo
… preferred styling & remove unneeded newling in PP tests
DTBTSDK-3612
Summary of changes
/v1/paypal_hermes/create_payment_resource&/v1/paypal_hermes/setup_billing_agreementURL response parsing into new fileBTPayPalApprovalURLParserURLComponentspaypalAppApprovalUrlresponse param present from gatewayChecklist
Added a changelog entryAuthors
@scannillo