Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QL] Add additional POST params to /setup_billing_agreement API call #1228

Merged
merged 27 commits into from
Mar 21, 2024

Conversation

scannillo
Copy link
Contributor

Summary of changes

  • Add 4 top-level POST params to v1/paypal_hermes/setup_billing_agreement if a merchant opts into the PP App Switch flow

Checklist

  • Added a changelog entry

Authors

@scannillo

jaxdesmarais and others added 21 commits March 11, 2024 14:28
…llocate BTPayPalClient so we can register the client on return
…ient-protocol-conformance

# Conflicts:
#	Demo/Application/Base/SceneDelegate.swift
#	Demo/Application/Features/PayPalWebCheckoutViewController.swift
#	Sources/BraintreeCore/BTAppContextSwitcher.swift
…equest to allow only PayPal module to use this param
@scannillo scannillo requested a review from a team as a code owner March 19, 2024 13:39
@scannillo scannillo changed the title [PP App Switch] Add additional POST params to /setup_billing_agreement API call [QL] Add additional POST params to /setup_billing_agreement API call Mar 19, 2024
Copy link
Contributor

@agedd agedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

@scannillo
Copy link
Contributor Author

Will wait until #1227 is merged

Base automatically changed from add-enablePayPalAppSwitch-to-vault-request to paypal-app-switch-feature March 20, 2024 20:03
@scannillo scannillo merged commit 657456b into paypal-app-switch-feature Mar 21, 2024
7 checks passed
@scannillo scannillo deleted the add-ba-post-params branch March 21, 2024 21:03
@scannillo scannillo mentioned this pull request Mar 22, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants