EPS-575: Resolved Console error for undefined left in navigation menu #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijetaR
reviewed
Jun 10, 2024
inc/js/frontend.js
Outdated
| @@ -621,17 +621,16 @@ | |||
|
|
|||
| $this.addClass( 'hfe-active-menu' ); | |||
| $this.attr( 'aria-expanded', 'true' ); | |||
|
|
|||
There was a problem hiding this comment.
Remove this additional space.
vijetaR
reviewed
Jun 10, 2024
| @@ -581,8 +581,8 @@ | |||
|
|
|||
| $( '.elementor-element-' + id + ' .hfe-nav-menu__toggle' ).next().css( 'left', '0' ); | |||
|
|
|||
| var width = $( '.elementor-element-' + id ).closest('.elementor-section').outerWidth(); | |||
| var sec_pos = $( '.elementor-element-' + id ).closest('.elementor-section').offset().left - $( '.elementor-element-' + id + ' .hfe-nav-menu__toggle' ).next().offset().left; | |||
| var width = $('.elementor-element-' + id).closest('*').parent().outerWidth(); | |||
There was a problem hiding this comment.
Please verify these changes for container and section, and compare it with release-candidate branch.
earth9890
changed the title
earth9890
changed the title
|
Tested. Working fine at my end. Please pull RC and add a changelog for the fix. @earth9890 |
vijetaR
approved these changes
Jun 16, 2024
|
There are still conflicts left in there. |
vijetaR
reviewed
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After clicking the navigation menu, a console error "left is undefined" was displayed. This occurred because the left value, which is returned by the offset method, was not available since the class passed in the closest method was missing. Now, if the full width option is turned on, it will use the width of its container.
Screenshots
https://drive.google.com/file/d/1f8Ps92G2_tr7QNQ2E41XeErboA68p8U2/view?usp=sharing
Types of changes
How has this been tested?
Checklist: