Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bad channel using partial name #709

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Edouard2laire
Copy link
Contributor

Hello,

In nirs, sometime it can be useful to mark a detector, or a source as bad as we know from the acquisition that this detector or source was not well placed. Currently, to remove S1, for example, we have to write S1D1WL680, S1D1WL830, S1D2WL680, S1D2WL830, ... to list all the channels containing S1 which is awful :)

This allows to write S1 to remove all the channels using S1; or D1 for all the channels using D1; even S1D1 (instead of S1D1WL830, S1D1WL680).

This is however a bad fix as writing S1 would also remove S10. I'll try to find a better solution; unless you have an idea :)

Edouard

@rcassani
Copy link
Member

rcassani commented Jun 3, 2024

@Edouard2laire, an idea would be to be able use regular expressions in the channel name field to select the channels to remove e.g.:

regexp "^S1(?=D)" Any channel using S1, not including S10
regexp "^S1(?=D)D1(?=W)" Any channel using S1D1, no including S10 nor D10
regexp "^S\d*(?=D)D1(?=W) Any channel using D1 regardless of the Source

  • These examples require to have the format S%dD%dWL%d

While regular expressions are very useful, writing them and reading their syntax may take more time that typing the name of the channels. This may be also challenging when sharing codes with others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants