Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Update CI deployment to use NI unit actions #168

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

willGraham01
Copy link
Collaborator

@willGraham01 willGraham01 commented Aug 14, 2023

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

Re-enables automatic deployment when a new tag is pushed to main. Currently, the workflow is still trying to build the package using twine, setuptools, and setup.py; however the package now uses a pyproject.toml file.

What does this PR do?

Updates the test_and_deploy workflow to use the NI-unit actions.
This also means that the old deployment method no longer searches for setup.py, which was causing deployments to fail.

@willGraham01 willGraham01 requested a review from a team August 14, 2023 13:06
@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Aug 14, 2023

Preview page for your plugin is ready here:
https://preview.napari-hub.org/brainglobe/cellfinder-napari/168
Updated: 2023-08-14T13:14:58.357470

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (832bbed) 95.36% compared to head (d4060b7) 95.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #168   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          17       17           
  Lines         798      798           
=======================================
  Hits          761      761           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamltyson adamltyson merged commit 16444e7 into main Aug 21, 2023
@willGraham01 willGraham01 deleted the update-CI-deployment branch August 21, 2023 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants