This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
avoid using deprecated pkg_resources #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 99.13% 99.13%
=======================================
Files 9 9
Lines 231 231
=======================================
Hits 229 229
Misses 2 2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dstansby
approved these changes
Mar 10, 2023
willGraham01
pushed a commit
that referenced
this pull request
Aug 24, 2023
* Add docstrings/typing to utils.py * Add docstring to sample data * Add docstrings/typing to thread_worker.py * Add docstrings/typing to detect.py * Add missing None return typing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Description
What is this PR
Why is this PR needed?
We use
pkg_resourceswhich is deprecated (and therefore our tests fail).What does this PR do?
Uses a relative path to config files instead of
pkg_resources.filename.References
How has this PR been tested?
Tests were failing before due to the deprecation warning, and now pass.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: