This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
CI Check against tensorflow include guard
#204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willGraham01
force-pushed
the
include-guard-test
branch
from
a900560 to
0c63066
Compare
willGraham01
changed the title
tensorflow include guard
|
|
alessandrofelder
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
While this all looks good, we should note that the original issue this closes was only encountered on Silicon Macs, and therefore this test wouldn't have caught it (
I think (thought?) we had an issue to expand CI to new Macs, but I can't find it for the life of me. Maybe we should open another one?
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Description
What is this PR
Why is this PR needed?
Tests the include-guard that denies use of the tools when
tensorflowis not available.What does this PR do?
Adds a short check to make sure that the
tensorflowinclude guard is behaving itself onubuntuandmacOS.pip install -e .should successfully fetchtensorflowand allow import.tensorflowis not installed, importing the module should fail. Conditions for this test are achieved by having pip uninstalltensorflow.References
How has this PR been tested?
Locally running the commands produces the outcomes that are checked against.
New workflow has been introduced to check the results are as expected on CI.
Is this a breaking change?
No
Does this PR require an update to the documentation?
Checklist: