This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
ensure cellfinder-core can run on single cpu #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoids n_ball_procs becoming zero if only one cpu available parametrise integration test to run on both many and one cpu
alessandrofelder
force-pushed
the
run-on-one-cpu
branch
from
fbfa7ab to
ffdfbbe
Compare
|
Still need to test this on a real-life dataset (first thing tomorrow) - will confirm here. |
|
Should we add tests for |
I think it's not much work to add the additional tests to this workflow, and takes pressure off the merging repo timeline, so a good idea? Opened brainglobe/cellfinder#277 |
7 tasks
adamltyson
approved these changes
Jul 14, 2023
|
Confirming this ran on real-life large test data on 1 CPU and gave the same result as with 17 CPUs (took ~2:15 h instead of 1:05 h) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
It's currently possible for cellfinder-core to spawn a threadpool with 0 processes.
See brainglobe/cellfinder-napari#157
What does this PR do?
Ensures
n_ball_procsis always at least 1, and therefore a thread pool with 0 processes is never spawned.References
Closes #197 and should get us most of the way to brainglobe/cellfinder-napari#157
How has this PR been tested?
Added a test parameter to check this edge case
Is this a breaking change?
No
Checklist: