Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Type ball filter #133

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Apr 4, 2023

This finishes typing on BallFilter. Because the filter doesn't work when some of the initial arguments are None, I've just removed all the default arguments to keep it simple.

@dstansby dstansby marked this pull request as ready for review April 4, 2023 10:02
@dstansby dstansby requested a review from a team April 4, 2023 10:02
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thank you!

@alessandrofelder alessandrofelder merged commit 5e353bd into brainglobe:main Apr 4, 2023
@dstansby dstansby deleted the type-ball-filter branch April 4, 2023 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants