Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Test for error when data dimensionality is wrong #131

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Apr 4, 2023

Adds a bit more test coverage. Also updates the error type from IOError to ValueError, as the error is being raised because of an issue with a value passed to a function, not an issue with input/output.

@dstansby dstansby marked this pull request as ready for review April 4, 2023 09:23
@dstansby dstansby requested a review from a team April 4, 2023 09:24
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 🎉

@alessandrofelder alessandrofelder merged commit 1fce9cd into brainglobe:main Apr 4, 2023
@dstansby dstansby deleted the data-dim-error branch April 4, 2023 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants