This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Collect coverage of numba decorated code #124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
dstansby
force-pushed
the
numba-coverage
branch
2 times, most recently
from
March 31, 2023 09:50
1c7fc65
to
afa5ea2
Compare
This seems to work well, but the tests with Numba turned off takes 13 minutes to run. I'm on the fence about whether this is too slow or not for regular CI. I will take a look and see if there's a way to run the slower Numba off run only on merges to |
Currently wainting on neuroinformatics-unit/actions#18 |
dstansby
force-pushed
the
numba-coverage
branch
from
April 21, 2023 08:00
5fc338d
to
f68886e
Compare
dstansby
changed the title
Add CI with Numba turned off
Collect coverage of numba decorated code
Apr 21, 2023
adamltyson
approved these changes
Apr 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110. This adds a new CI workflow that only runs on
main
that disables numba, and therefore collects code coverage for the parts of the code that would otherwise be optimised by numba. The tests are slow (~20 mins), but not unreasonably slow, so running them only on commits tomain
seems like a good compromise.I've also enabled carryforward flags for these parts of the code in codecov. This will automatically carry forward the covered lines on main to pull requests, so coverage isn't going up and down in
main
compared to pull requests where the new workflow isn't run.