Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Misc classification typing #106

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Conversation

dstansby
Copy link
Member

While I was looking at the tensorflow issue, I started typing some of the classification code. This is very incomplete, but since I don't intend to come back to it in the near future, I figured it's worth adding what I did instaed of losing it.

@dstansby dstansby force-pushed the misc-classify-typing branch from 0531fa7 to d46f865 Compare March 28, 2023 13:40
@dstansby dstansby marked this pull request as ready for review March 28, 2023 13:40
@dstansby dstansby requested a review from a team March 28, 2023 13:41
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (23e1353) 99.25% compared to head (d46f865) 99.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files           9        9           
  Lines         269      269           
=======================================
  Hits          267      267           
  Misses          2        2           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/cellfinder_core/classify/cube_generator.py Outdated Show resolved Hide resolved
src/cellfinder_core/classify/cube_generator.py Outdated Show resolved Hide resolved
@dstansby dstansby force-pushed the misc-classify-typing branch from 03de274 to c3e65c4 Compare March 30, 2023 12:27
@dstansby dstansby requested a review from adamltyson March 30, 2023 12:29
@adamltyson adamltyson merged commit 721ccc7 into brainglobe:main Mar 30, 2023
@dstansby dstansby deleted the misc-classify-typing branch March 30, 2023 15:40
willGraham01 pushed a commit that referenced this pull request Aug 24, 2023
* Test that marking cells and non-cells works in curation

* Improve test variable names
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants