Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename incorrect instances of cellfinder to brainmapper #67

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

adamltyson
Copy link
Member

@adamltyson adamltyson commented Jan 4, 2024

Before release, this will need brainglobe-napari-io to be updated to detect the renamed brainmapper.json.

Closes #63

As it turns out the log file is named automatically, so this just changes the metadata file.

@adamltyson adamltyson requested a review from a team January 4, 2024 12:16
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2da996a) 81.39% compared to head (17a52a1) 81.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   81.39%   81.33%   -0.07%     
==========================================
  Files          32       32              
  Lines        1586     1586              
==========================================
- Hits         1291     1290       -1     
- Misses        295      296       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamltyson
Copy link
Member Author

brainglobe/brainglobe-napari-io#59 has been created to support this change. Both packages will need re-releasing, with workflows depending on the latest version of brainglobe-napari-io.

@adamltyson
Copy link
Member Author

Following the merge of brainglobe/brainreg#172, this package should also pin the latest version of brainreg upon release.

Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alessandrofelder alessandrofelder merged commit 00f33d2 into main Jan 5, 2024
9 of 10 checks passed
@alessandrofelder alessandrofelder deleted the brainmapper branch January 5, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update log & metadata saving to use the brainmapper name rather than cellfinder
2 participants