pin to pytorch-version of cellfinder #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willGraham01
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Worth noting that the meta-package doesn't have a latest release that includes cellfinder >=1.3.0 (latest metapackage release is v1.1.0 which only pins `cellfinder >=1.2.9).
So it might also be worth bumping the brainglobe dependency to (at least) 1.1.0, maybe higher if we make a quick metapackage release.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 85.83% 85.83%
=======================================
Files 17 17
Lines 847 847
=======================================
Hits 727 727
Misses 120 120 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Latest release of
brainglobe-workflowsis incompatible with latestcellfinder, because it tries to importtensorflow-related functionality. This is fixed in the development code by #112 but not released yet.What does this PR do?
Makes sure the next release pins to a cellfinder version >= 1.3.0, so the API between the two packages in in-sync and up-to-date.
References
\
How has this PR been tested?
Not sure how to test this 😬 I have convinced myself I have thought this through.
Is this a breaking change?
No. It's an adaptation to the latest cellfinder release.
Does this PR require an update to the documentation?
No
Checklist: