Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding simple benchmark #115

Closed
wants to merge 2 commits into from
Closed

Adding simple benchmark #115

wants to merge 2 commits into from

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented May 31, 2024

A draft PR adding a benchmarking for brainglobe atlasapi
TODO

  • document how to write benchmarks

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

What does this PR do?

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 85.22%. Comparing base (86c292c) to head (b86a6b8).

Files Patch % Lines
...orkflows/brainglobe_atlasapi/create_mouse_atlas.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   85.83%   85.22%   -0.61%     
==========================================
  Files          17       18       +1     
  Lines         847      853       +6     
==========================================
  Hits          727      727              
- Misses        120      126       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig force-pushed the pp/simple-benchmark branch from 06e85d2 to b86a6b8 Compare May 31, 2024 16:59
@sfmig
Copy link
Contributor Author

sfmig commented Jul 17, 2024

This PR was a pair-programming exercise to go through the steps of writing a new benchmark.

Closing it for now since it won't be implemented.

@sfmig sfmig closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant