-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement dask-downsampling #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I expect tests to pass once #22 is merged. |
alessandrofelder
force-pushed
the
dask_downsampling
branch
2 times, most recently
from
August 15, 2024 10:46
53fe2d7
to
86f8888
Compare
alessandrofelder
force-pushed
the
dask_downsampling
branch
from
August 15, 2024 11:00
86f8888
to
b7bd0cf
Compare
for more information, see https://pre-commit.ci
niksirbi
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some clarifying comments, but nothing blocking.
Feel free to address and merge as you wish.
alessandrofelder
force-pushed
the
dask_downsampling
branch
from
August 15, 2024 13:50
4121b0f
to
6f87098
Compare
alessandrofelder
force-pushed
the
dask_downsampling
branch
from
August 15, 2024 13:57
6f87098
to
6e12335
Compare
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
It's useful for at least the tadpole data (and hopefully many others) preprocessing to effectively downsample data, both for initial low-res atlases (for testing), and later higher-res production-ready atlases.
What does this PR do?
Adds a function to downsample an image in xy, and then z, with Dask.
This could be moved to utils, maybe, in a later step.
References
\
How has this PR been tested?
Simple tests added, trying not to over-engineer at this point in the package's history.
Is this a breaking change?
No
Does this PR require an update to the documentation?
Docstrings added. Documenting this package on a higher level is out-of-scope for this PR
Checklist: